Azure / Azure-Spring-Apps

Azure Spring Cloud
MIT License
8 stars 5 forks source link

Azure Quickstart Templates for ASA to be provided #28

Open ezYakaEagle442 opened 1 year ago

ezYakaEagle442 commented 1 year ago

Is your feature request related to a problem? Please describe. There is no ARM/Bicep Template for ASA. The only one is outdated since 2 years at https://github.com/Azure/azure-quickstart-templates/tree/master/quickstarts/microsoft.appplatform/azure-spring-cloud

Describe the solution you'd like At least 2 FULL Bicep Template + ARM Template should be provided as quick starts that should then be published at https://github.com/Azure/azure-quickstart-templates :

  1. minimum settings with Standard Tier
  2. ALL settings with Enterprise Tier including SSO, Cloud Gateway, API Portal, Build Service, Dev tools/ACME Accelerator

Describe alternatives you've considered There is this branch https://github.com/Azure-Samples/spring-petclinic-microservices/tree/enterprise but all the bindings are run through CLI for instance, not in Bicep

Also this https://learn.microsoft.com/en-us/azure/spring-apps/quickstart-deploy-infrastructure-vnet-bicep?tabs=azure-spring-apps-enterprise

Additional context I use my own Template available at https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/blob/azure/iac/bicep/modules/asa/asa-e.bicep

allxiao commented 1 year ago

Currently, we leverage the automated generated API and Bicep documentation from our API swagger definitions. You can check the documentation site for reference.

The docs provide full templates for all the Azure Spring Apps resources. If you want to get the effective part of the operations mentioned in the Azure Spring Apps documentation and written in Azure CLI commands, you can add --debug --verbose to the given command and check the payload passed to ARM. You can modify the Bicep / ARM template accordingly.

We put the task to add Bicep code samples in public documentation into Backlog, while we will actively improve the description for each API field to make it more clear what this field is and the values it will accept.

ezYakaEagle442 commented 1 year ago

Currently, we leverage the automated generated API and Bicep documentation from our API swagger definitions. You can check the documentation site for reference.

The docs provide full templates for all the Azure Spring Apps resources. If you want to get the effective part of the operations mentioned in the Azure Spring Apps documentation and written in Azure CLI commands, you can add --debug --verbose to the given command and check the payload passed to ARM. You can modify the Bicep / ARM template accordingly.

We put the task to add Bicep code samples in public documentation into Backlog, while we will actively improve the description for each API field to make it more clear what this field is and the values it will accept.

NO, this is just the Bicep template doc for ASA, it does NOT help, anyone can find this doc, but without real values then it is useless

The ask here is to provide actual values in a snippet like I did at https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/blob/azure/iac/bicep/modules/asa/asa-e.bicep

https://github.com/ezYakaEagle442/azure-spring-apps-petclinic-mic-srv/blob/azure/iac/bicep/modules/asa/asa-e-api-portal-gateway.bicep

hangwan97 commented 1 year ago

In the past several months, the structure of the doc has been updated after the azure spring cloud to azure spring apps name change.

The functions and usages of Quickstart have also changed accordingly as the main purpose of quickstart is just to provide day 1 quick and easy walk-through.

The team is now adding quickstart templates to the repo. Preview link: https://review.learn.microsoft.com/en-us/azure/spring-apps/quickstart-template?branch=pr-en-us-237947&pivots=sc-enterprise&tabs=Azure-portal.

As the quickstart is now extending to a list of popular spring workloads: https://learn.microsoft.com/en-us/azure/spring-apps/quickstart-deploy-event-driven-app-standard-consumption?pivots=sc-standard web app event-driven app micro-service app(s) ...

The Bicep Template + ARM Template related docs are currently under the 'how-to': https://learn.microsoft.com/en-us/azure/spring-apps/quickstart-deploy-infrastructure-vnet?tabs=azure-spring-apps-standard%2Cazure-cli

The update of how-to will be updated in the upcoming months.

moarychan commented 10 months ago

The quickstart template for microservices(PetClinic) is available, please check microservice-apps-enterprise-plan.