search

Azure / Azure-TDSP-Utilities

Utilities and scripts developed as part of Microsoft's Team Data Science Process for productive data science
Creative Commons Attribution 4.0 International
373 stars 275 forks source link

Bug in extracting new date/time variables in the IDEAR.rmd file #42

Open lucazav opened 5 years ago

lucazav commented 5 years ago

I found a bug in the chunk of code that creates new variables from a date/time one. Here my suggestions:

autogen_datetime_columns <- character()
if(!is.null(config$DateTimeColumns[[1]])){
  for (i in 1:length(config$DateTimeColumns) ) {  #<-- new
  #for (dt in names(config$DateTimeColumns)) {    #<-- old
    dt <- names(config$DateTimeColumns[[i]])
    data[[dt]] <- as.POSIXct(data[[dt]], format = config$DateTimeColumns[[i]][[dt]])  #<-- new
    #data[[dt]] <- as.POSIXct(data[[dt]], format = config$DateTimeColumns[[dt]])      #<-- old
...

HTH