Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
364 stars 85 forks source link

[Module Proposal]: `avm/ptn/network/virtual-wan` #1011

Open ChrisSidebotham opened 5 months ago

ChrisSidebotham commented 5 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/network/virtual-wan

Module Details

Bicep version of the current terraform pattern module https://github.com/Azure/terraform-azurerm-avm-ptn-virtualwan

Ownership to be confirmed. Initial development will be done by myself. with the perspective owners Eric Scheffler and Jaun Jiminez (FTE's). GH Handles TBC

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

ericscheffler

(Optional) Secondary Module Owner's GitHub Username (handle)

juancji

ChrisSidebotham commented 5 months ago

@matebarabas - owners added above :)

matebarabas commented 5 months ago

Thanks, @ChrisSidebotham! @ericscheffler, let's continue with our standard "handshake" process! 👍

matebarabas commented 5 months ago

Hi @ericscheffler,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

ericscheffler commented 5 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 5 months ago

Hi @ericscheffler,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

ericscheffler commented 4 months ago

Currently working on adding some VWAN pattern resource dependencies prior to implementing this pattern; Routing Intent (in progress), P2S GW and P2S User Configuration will all be required prior to creating this pattern to ensure it is complete.

ericscheffler commented 2 weeks ago

Routing Intent and P2S User Configuration resources have been completed and PR'ed, working on P2S GW presently, ~75% complete.