Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
362 stars 85 forks source link

[Module Proposal]: `avm/ptn/openai/e2e-baseline` #1048

Open amillerb opened 5 months ago

amillerb commented 5 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/openai/e2e-baseline

Module Details

This pattern will assist with adding additional security guardrails to the OpenAI end-to-end baseline article from the Azure Architecture Center cited here: Baseline OpenAI end-to-end chat reference architecture. In this update, the reference architecture and implementation via bicep will be executed in a zero trust manner by adding an Azure Firewall for additional inspection, rules to the NSGs and other network security constructs.

This pattern will be providing a quick start mechanism for customers wanting to use Azure Open AI in a best practice manner and by incorporating the use of AVM modules to the overall solution. Below is a list of resources that would be part of the planned module:

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

amillerb

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

matebarabas commented 5 months ago

@amillerb, thank you for proposing this module! As this is categorized as a pattern module, its approval will require a more thorough assessment. The AVM core team will get back to you soon. Thank you for your patience!

jtracey93 commented 5 months ago

@amillerb can you confirm that this ptn module will also create the the Azure OpenAI service as well as per the baseline architecutre?

amillerb commented 5 months ago

Hi @jtracey93 - This pattern will include the components from the baseline reference implementation bicep (https://github.com/Azure-Samples/openai-end-to-end-baseline) and the addition of a firewall to the e2e architecture.

matebarabas commented 5 months ago

Hi @amillerb,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

amillerb commented 5 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 5 months ago

Hi @amillerb,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

microsoft-github-policy-service[bot] commented 4 months ago

[!IMPORTANT] @amillerb, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @amillerb, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @amillerb, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

matebarabas commented 2 months ago

@amillerb, I just pinged you internally regarding the inactivity on this module's development. Please let me know how you're planning to proceed. Thanks!

amillerb commented 2 months ago

Hi @matebarabas - ran into some delays with this module. Re-shifted focus to a related article, the app baseline, which shares many of the same components, except for Open AI.

Planning on completion by the end of this year.

amillerb commented 2 months ago

Working Branch: https://github.com/amillerb/bicep-registry-modules/tree/aoai-avm

matebarabas commented 2 months ago

@amillerb, this is great news; thanks for sharing! Once you'll have a PR (even if it's draft), please provide a link to it as well! Thank you!