Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
354 stars 83 forks source link

[Module Proposal]: `avm-res-network-applicationgatewaywebapplicationfirewallpolicy` #1088

Open PmeshramPM opened 5 months ago

PmeshramPM commented 5 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-network-applicationgatewaywebapplicationfirewallpolicy

Module Details

AVM Resource Module for Application Gateway Web Application Firewall (WAF) Policy

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

cshea-msft commented 2 months ago

@PmeshramPM Is this just adding the waf policy to app gw?

prjelesi commented 2 months ago

@cshea-msft this should create waf policy using this rp https://learn.microsoft.com/en-us/azure/templates/microsoft.network/applicationgatewaywebapplicationfirewallpolicies?pivots=deployment-language-arm-template

cshea-msft commented 2 months ago

@prjelesi ok so it's just creating a Web Application Firewall. https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/web_application_firewall_policy

@mofaizal is the owner of the appgw module, so he might want to own this.

matt-FFFFFF commented 2 months ago

This module doesn't make sense. The firewall policy is a dedicated resource that's shared with other resources.

The output of the waf policy module will be used in the existing appgw module

prjelesi commented 2 months ago

We are good to go to move this module to dev. @cshea-msft @mofaizal Who is raising hand to own it?

sihbher commented 2 months ago

Just in case no one could own this module, I would like to own it.

prjelesi commented 2 months ago

Just in case no one could own this module, I would like to own it.

Let's wait @cshea-msft and @mofaizal to reply.

cshea-msft commented 1 month ago

@prjelesi i don't need to own it

prjelesi commented 1 month ago

@mofaizal

prjelesi commented 4 weeks ago

@mofaizal

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

mofaizal commented 4 weeks ago

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

kewalaka commented 2 weeks ago

here's a sample here that passes static code checks (tflint, grept etc)

https://github.com/kewalaka/terraform-azure-avm-res-network-applicationgatewaywebapplicationfirewallpolicy/tree/feat/initial-version

mofaizal commented 2 weeks ago

@kewalaka Thanks for your support, here is the Repo link to PR https://github.com/Azure/avm-res-network-applicationgatewaywebapplicationfirewallpolicy