Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
365 stars 87 forks source link

[Module Proposal]: `avm/ptn/network/vwan-connected-vnets` #1132

Open juancj opened 5 months ago

juancj commented 5 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/network/vwan-connected-vnets

Module Details

Currently we have some bicep templates that we used to create VNET and VMs that are connected to a hub of Virtual WAN. The template assumes that there is a VWAN instance with its hubs already deployed.

Our deployment takes care of creating the VNET/VM and vWAN Connection to an existing hub so that the VM are network routable one the deployment is completed. The deployment also Domain Join the VMs and managed credentials via private traffic to a KeyVault.

Edit (from internal discussions): This patterns provides a way for teams using a centralized infra (not managed by them) to connect (VNETs/VMs, Hub connection) resources to it so they can build their services using other shared services that reside in the centralized infra (FW, ER, P2S, etc...).

This module will leverage the following resources (resource modules that encapsulate these):

This module will leverage the following resources directly (without using a resource module):

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

juancj

(Optional) Secondary Module Owner's GitHub Username (handle)

ericscheffler

matebarabas commented 5 months ago

@juancj, thank you for proposing this module! As this is categorized as a pattern module, its approval will require a more thorough assessment. The AVM core team will get back to you soon. Thank you for your patience!

ChrisSidebotham commented 4 months ago

@hundredacres - Does this conflict with the hub-networking pattern you have?

hundredacres commented 4 months ago

@ChrisSidebotham I don't think so but would need to see some code.

raghuvenkat2005 commented 4 months ago

@ChrisSidebotham & @hundredacres - Could you please provide an estimated timeline for completing the review?

ChrisSidebotham commented 4 months ago

@juancj - Will this module be leveraging the current virtual machine module for the compute deployment capabilities?

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @juancj, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @juancj, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @juancj, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] @juancj, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 3 weeks ago

[!IMPORTANT] @juancj, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 2 days ago

[!IMPORTANT] @juancj, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.