search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
317 stars 65 forks source link

[Module Proposal]: `avm/ptn/azd/insights-dashboard` #1206

Open Menghua1 opened 1 month ago

Menghua1 commented 1 month ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/azd/insights-dashboard

Module Details

Please add a Pattern Module named avm/ptn/azd/insights-dashboard, this module will create the following two resources:

  1. Application Insights instance based on an existing Log Analytics workspace.
  2. Portal Dashboard for an Application Insights instance.

For details, please refer to azd: https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/monitor/applicationinsights.bicep

https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/monitor/applicationinsights-dashboard.bicep

CC: @jongio

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

jongio

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

ChrisSidebotham commented 1 month ago

@jongio - Would a suitable owner for this module be identified from your team or do we need to look elsewhere?

jongio commented 1 month ago

@Menghua1 - Please add more details to this proposal on what this module will do exactly.

Menghua1 commented 1 month ago

@jongio I've updated Module Details in the Description.

jongio commented 1 month ago

@ChrisSidebotham - I can signup to be the owner of this and all azd related pattern modules. What's the best way to do that?

matebarabas commented 1 month ago

Hi @jongio, @jeanchg and I will reach out to you internally once you're back next week to clarify the context and some of our questions on this and all the other related pattern module proposals @Menghua1 has recently submitted.

jongio commented 1 week ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 1 week ago

Hi @jongio,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR