Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
317 stars 65 forks source link

[Module Proposal]: `avm/ptn/azd/container-apps` #1225

Open Menghua1 opened 1 month ago

Menghua1 commented 1 month ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/azd/container-apps

Module Details

Please add a Pattern Module named avm/ptn/azd/container-apps, this module will create the following two resources:

  1. Container App Environment.
  2. Azure Container Registry (ACR).

For details, please refer to azd: https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/host/container-apps.bicep

CC: @jongio

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

jongio

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

matebarabas commented 1 month ago

@Menghua1, thank you for proposing this module and thank you for your patience on triaging it! Many of us on the AVM core team have been OOF in the last couple of weeks, but we're back now! 😊

As this is categorized as a pattern module, its approval will require a more thorough assessment. We'll reach out to @jongio internally for more context and details as this proposal may require some adjustments to fit AVM's pattern definition and intent. The AVM core team will get back to you soon. Thank you for your patience!

matebarabas commented 2 weeks ago

Hi @jongio,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

jongio commented 1 week ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 1 week ago

Hi @jongio,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

matebarabas commented 3 days ago

Thank you for your work @NanaXiong00!

CC: @jongio