search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
321 stars 68 forks source link

[Module Proposal]: `avm/res/app/container-app` #128

Closed oZakari closed 7 months ago

oZakari commented 11 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in another project that is being evolved into AVM

Terraform or Bicep?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/app/container-app

Module Details

Not proposing a new module but interested in taking ownership of existing CARML module.

For reference: https://github.com/Azure/ResourceModules/tree/main/modules/app/container-app

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username

oZakari

matebarabas commented 11 months ago

@oZakari, thanks for opening this request and volunteering! I'll shortly send you a request to officially confirm ownership.

Also, @prjelesi is going to reach out to you separately and help with the next steps, given this is a migrate from CARML scenario.

Thank you!

matebarabas commented 11 months ago

Hi @oZakari,

Thanks for requesting/proposing to be an AVM module owner.

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know.

If you agree please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

oZakari commented 11 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 11 months ago

Reopening.

@oZakari, please note that this issue can only be closed when the module is developed, tested, and published in the Bicep public registry.

matebarabas commented 11 months ago

Hi @oZakari,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities.

We just want to ask you to double check a few important things before you start the development.

Please visit the module index page of your module and use the following values explicitly as provided there:

You can now start the development of this module! Happy coding! 🎉

Please respond to this comment, once your module is ready to be published!

Any further questions or clarifications needed, let us know.

Thanks,

The AVM Core Team

kewalaka commented 11 months ago

semantics perhaps - but would avm-res-container-app be a better choice? There is avm-res-container-registry, and presumably there will need to be one for managed environments (avm-res-container-environment ?)

seems more logical to me to place the container items closer together alphabetically

If the intent is to group various app options together, then I think the appservice repository name needs reconsideration?

oZakari commented 11 months ago

Hi @kewalaka, the spec is where that naming convention came from. I think this was done to try to reduce the number of dashes for resource names with lots of spaces and to try to keep it as consistent as possible with the resource schema itself. For container registry it should be avm-res-containerregistry-registry instead of avm-res-container-registry.

@matebarabas Just taking a quick look at other resource module names, looks like module for Action Group has a hypen, but it shouldn't either unless I am missing something.

matebarabas commented 11 months ago

@ozakari, @kewalaka,

Please see the naming convention for resource and pattern modules under the respective shared requirement.

matebarabas commented 10 months ago

@oZakari,

Due to a recent change in the naming convention for AVM Bicep modules, this module is getting an updated name.

The title and description of this GH issue has been updated to reflect the name change. Please make sure you adhere to the new naming convention when publishing your module!

Please see the new naming convention in:

Please note that the Telemetry ID and name of GitHub Teams haven't changed.

If you feel uncertain about any details, please check the Bicep modules indexes.

oZakari commented 9 months ago

Working branch from fork for reference: https://github.com/oZakari/bicep-registry-modules/tree/container-apps

matebarabas commented 9 months ago

Thanks for the update @oZakari! Please let us know once you've submitted a PR (by providing a link to it). Thank you in advance!

matebarabas commented 8 months ago

Hi @oZakari, Happy New Year! I hope you had a great holiday season and had a chance to recharge! 😊

I just would like to check back on this issue and ask how far do you think you are? Can you please share your expected timeline on publishing this module?

Thank you!

CC: @jeanchg

oZakari commented 8 months ago

Hi @matebarabas, nearly complete, pushing to get the PR out by this Friday.

oZakari commented 8 months ago

PR Link in Bicep Registry

matebarabas commented 7 months ago

Thank you for your work @oZakari! I'm closing this issue now.