Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
320 stars 67 forks source link

[Module Proposal]: `avm-ptn-azuremonitorwindowsagent` #1284

Open xhy8759 opened 1 month ago

xhy8759 commented 1 month ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Pattern Module

Module Name

avm-ptn-azuremonitorwindowsagent

Module Details

Provider is Microsoft.AzureStackHCI/clusters/ArcSettings/Extensions@2023-08-01

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

xhy8759

(Optional) Secondary Module Owner's GitHub Username (handle)

duzitong

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation.

microsoft-github-policy-service[bot] commented 1 month ago

@xhy8759, thanks for volunteering to be a module owner!

[!IMPORTANT] Please don't start the development just yet!

The AVM core team will review this module proposal and respond to you first. Thank you!

prjelesi commented 1 month ago

We are changing this to be resource deployment with this child configuration. @xhy8759 i will update module request to align with resource module name and process.

xhy8759 commented 1 month ago

I would like to request a review of my module. The latest code is in a PR titled AVM-Review-PR on the module repo and all checks on that PR are passing. Here is our PR link: https://github.com/Azure/terraform-azurerm-avm-ptn-azuremonitorwindowsagent/pull/1

Test passes locally: extension

xhy8759 commented 2 weeks ago

The initial review of this module is complete, and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index. Terraform Registry Link: https://registry.terraform.io/modules/Azure/avm-ptn-azuremonitorwindowsagent/azurerm/latest GitHub Repo Link: https://github.com/Azure/terraform-azurerm-avm-ptn-azuremonitorwindowsagent