search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
345 stars 81 forks source link

[Module Proposal]: `avm-res-azurestackhci-virtualmachineinstance` #1288

Closed xhy8759 closed 3 weeks ago

xhy8759 commented 2 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-azurestackhci-virtualmachineinstance

Module Details

Provision for AzureStachHCI's VM. Provider is Microsoft.AzureStackHCI/virtualMachineInstances@2023-09-01-preview.

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

xhy8759

(Optional) Secondary Module Owner's GitHub Username (handle)

duzitong

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation.

microsoft-github-policy-service[bot] commented 2 months ago

@xhy8759, thanks for volunteering to be a module owner!

[!IMPORTANT] Please don't start the development just yet!

The AVM core team will review this module proposal and respond to you first. Thank you!

xhy8759 commented 2 months ago

I would like to request a review of my module. The latest code is in a PR titled AVM-Review-PR on the module repo and all checks on that PR are passing. Here is our PR link: https://github.com/Azure/terraform-azurerm-avm-res-azurestackhci-virtualmachineinstance/pull/1

Test passes locally: vm

xhy8759 commented 1 month ago

The initial review of this module is complete, and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index. Terraform Registry Link: https://registry.terraform.io/modules/Azure/avm-ptn-azuremonitorwindowsagent/azurerm/latest GitHub Repo Link: https://github.com/Azure/terraform-azurerm-avm-res-azurestackhci-virtualmachineinstance

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] @xhy8759, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.