search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
356 stars 84 forks source link

avm-ptn-subnets-nsgs-routes #1453

Open swathialuganti opened 1 month ago

swathialuganti commented 1 month ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Pattern Module

Module Name

avm-ptn-subnets-nsgs-routes

Module Details

This is a proposal for Pattern Module for creating subnets with network security group & route tables either created inline or supplied to the module.

The concept of this pattern module is to make it easier for workload teams, given a vnet by the platform team, to be able to create resource networking.

Teams can optionally bring existing route tables or NSGs (pass in by resource ID), or they can be created in this module, in which case the subnet is connected to the route table or NSG via the map key.

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

swathialuganti

(Optional) Secondary Module Owner's GitHub Username (handle)

pavanmog

VeronicaSea commented 1 month ago

Hi @swathialuganti & @prjelesi , check out this submodule terraform-azurerm-avm-res-network-virtualnetwork/modules/subnet at v0.4.2 · Azure/terraform-azurerm-avm-res-network-virtualnetwork (github.com)

kewalaka commented 3 weeks ago

hi - my proposal was built off the vnet module that @VeronicaSea mentions (I built this pattern module after helping on the vnet AVM).

i've raised a PR that incorporates my original code along with changes to the AVM template

cc @swathialuganti

kewalaka commented 3 weeks ago

the original module proposal was here - https://github.com/Azure/Azure-Verified-Modules/issues/970 - i'm unclear why this extra issue was created (@prjelesi can you advise, please?)

the above description is largely the same without the example.

i'm happy to relinquish the secondary owner in favour of pavanmog, if that was the reason.

microsoft-github-policy-service[bot] commented 1 day ago

[!IMPORTANT] @swathialuganti, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.