Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
359 stars 85 forks source link

[Module Proposal]: `avm/res/sql-virtual-machine/sql-virtual-machine` #1461

Open loflet opened 1 month ago

loflet commented 1 month ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/sql-virtual-machine/sql-virtual-machine

Module Details

This module deploys SQL Virtual Machine - https://learn.microsoft.com/en-us/azure/templates/microsoft.sqlvirtualmachine/sqlvirtualmachines?pivots=deployment-language-bicep

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

peterbud

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

matebarabas commented 1 month ago

Hi @loflet, thank you for proposing this module!

Please note that while you can't be the "owner" of this module as you're not a Microsoft FTE, you can definitely contribute to it, once we found an FTE module owner.

Can you please confirm that you're interested in contributing to this solution by writing code? Thank you!

loflet commented 1 month ago

Hi @matebarabas, yes I would like to contribute to this solution by writing code, I am writing my own modules right now for one customer and I think this AVM module will be very handy for scenarios where we are trying to move to avm modules as it support multiple modules together.

matebarabas commented 1 month ago

Perfect, thanks for confirming! I'll get back to you when I have someone lined up who can help with the administrative side of this module. In the meantime, please feel free to start working on the code. Thank you!

matebarabas commented 1 month ago

@loflet, as we discussed via chat, @peterbud will help you as module owner. I'm going to administer this in our records.

matebarabas commented 1 month ago

Hi @peterbud,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

peterbud commented 1 month ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 1 month ago

Hi @peterbud,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

microsoft-github-policy-service[bot] commented 3 weeks ago

[!IMPORTANT] @peterbud, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 1 day ago

[!IMPORTANT] @peterbud, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

loflet commented 1 day ago

The work is in-progress on this module. I will update more once I have something to share for testing.