search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
354 stars 83 forks source link

[Module Proposal]: `avm/res/document-db/database-account/table` #1545

Closed seesharprun closed 4 weeks ago

seesharprun commented 1 month ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/document-db/database-account/table

Module Details

Azure Cosmos DB for Table now supports Microsoft Entra authentication (https://learn.microsoft.com/azure/cosmos-db/table/security).

As part of this, I'm working on Azure Developer CLI quickstart template using AVM modules and I noticed that I'm unable to create an account for Table as the capabilities array requires the account to be either NoSQL, MongoDB, or Apache Gremlin.

I'm planning a pull request to add the ability to create a table within an Azure Cosmos DB account.

I'm going to base it on this implementation: (https://github.com/Azure-Samples/cosmos-db-table-dotnet-quickstart/blob/2069c418a2bd8a9b3565e0456a9037d9582d7ad7/infra/core/database/cosmos-db/table/table.bicep)

And I will add the best practices from your current sub-resource implementations.

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

seesharprun

(Optional) Secondary Module Owner's GitHub Username (handle)

markjbrown

seesharprun commented 1 month ago

I'm working on this module update in this PR:

AlexanderSehr commented 4 weeks ago

Hey @seesharprun, I think this proposal can be closed. As of today, we don't need dedicated proposals for child-modules. @matebarabas I'll leave it ultimately up to you 😉

bryansan-msft commented 4 weeks ago

I would re-open an Issue in the module repository instead of closing it completely. It is weird to open a PR without an Issue backing up the PR

seesharprun commented 4 weeks ago

@bryansan-msft, I will reopen this as a proposal in the module repository. I was following a guide I saw to put a proposal here, but I could have misunderstood it.