search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
359 stars 85 forks source link

[Module Proposal]: `avm-ptn-subnet-nsg-routes` #1693

Open Dylan-Prins opened 2 weeks ago

Dylan-Prins commented 2 weeks ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

ptn/network/subnet-nsg-routes

Module Details

I want to create a module that creates a subnet with routes and security rules. This helps when you make use of landing zone vending, which only deploys a virtual network. I saw that there was an issue already for Terraform, but not for Bicep.

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

Dylan-Prins

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

jtracey93 commented 2 weeks ago

Hey @Dylan-Prins

Thanks for the proposal.

Can you expand a little further about what the module will do and add value over using resource modules to do this.

E.g. provide a baseline of NSG rules and UDRs ?

This'll help us make a decision on the module proposal 👍

Dylan-Prins commented 2 weeks ago

Hi @jtracey93,

Actually I am looking for a template to use when i get a landingzone connected to a hub. The platform team is deploying the vnet with peering and i only want to deploy the subnets.

Now I use AVM for everything except deploying the subnets.

jtracey93 commented 1 week ago

Ah okay that makes sense @Dylan-Prins

We are currently working on how we enable child modules for resource modules. This scenario would be covered when we have child modules available.

E.g. we will be able to publish the subnet as child module of the virtual network resource. Which will allow you to just deploy subnets.

Would you agree this would solve your challenge?

Dylan-Prins commented 1 week ago

@jtracey93 That would be a much better option! is there a ETA for the feature?

jtracey93 commented 1 week ago

We are discussing it each week, but no ETA just yet. But I don't think its a long way off. We are meeting later today, let me ask and then check-in there and report back here.

cc: @matebarabas @AlexanderSehr @eriqua @ReneHezser