search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
284 stars 61 forks source link

[Module Proposal]: `avm/res/digital-twins/digital-twins-instance` #206

Closed ChrisSidebotham closed 3 months ago

ChrisSidebotham commented 9 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/digital-twins/digital-twins-instance

Module Details

Migrate from CARML to BRM

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

ryanmstephens

(Optional) Secondary Module Owner's GitHub Username (handle)

No Response

jeanchg commented 9 months ago

@ChrisSidebotham, thanks for creating this module proposal. I'll send you a request to confirm ownership right after (you know the process already but it's just to be consistent with all module proposals). Thanks for all your contributions!

jeanchg commented 9 months ago

Hi @ChrisSidebotham,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

ChrisSidebotham commented 9 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 9 months ago

Hi @ChrisSidebotham,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

We just want to ask you to double check a few important things and take the next steps before you start the development.

Please use the following values explicitly as provided in the module index page:

Grant the right level of permissions for the AVM core team and PG teams on your GitHub repo as described here.

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment, once your module is ready to be published! 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.
matebarabas commented 8 months ago

@ChrisSidebotham,

Due to a recent change in the naming convention for AVM Bicep modules, this module is getting an updated name.

The title and description of this GH issue has been updated to reflect the name change. Please make sure you adhere to the new naming convention when publishing your module!

Please see the new naming convention in:

Please note that the Telemetry ID and name of GitHub Teams haven't changed.

If you feel uncertain about any details, please check the Bicep modules indexes.

ChrisSidebotham commented 7 months ago

@ryanmstephens - Let's catch up on this

ChrisSidebotham commented 6 months ago

Delayed till 2024

matebarabas commented 6 months ago

@ChrisSidebotham, I just would like to check back on the expected timeline: when do you think this could be done by? Are you actively working on this? Is there a blocker/dependency? Thanks!

CC: @jeanchg

ChrisSidebotham commented 5 months ago

@ryanmstephens - Any idea when you might get to this? I can migrate the module if you are happy to support it for any issues that are opened :)

matebarabas commented 5 months ago

Reopening. @ChrisSidebotham, I just spoke with @ryanmstephens internally and we concluded that it'd be great if you could please help with the migration and then Ryan could take care of the rest of the module's lifecycle. Can you please help with this one? Thanks!

ChrisSidebotham commented 5 months ago

Initial Import started....

microsoft-github-policy-service[bot] commented 4 months ago

@ChrisSidebotham, @ryanmstephens, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

matebarabas commented 4 months ago

@ryanmstephens, @ChrisSidebotham, can you please share any updates on this one? Thanks!

matebarabas commented 3 months ago

Thank you for your work @ChrisSidebotham! Please let me know when the missing team relationship is fixed, so I can close this issue.

ChrisSidebotham commented 3 months ago

This is now updated and completed @matebarabas

matebarabas commented 3 months ago

Thanks for confirming, I'm closing this issue now.

microsoft-github-policy-service[bot] commented 3 months ago

[!NOTE] The "Status: In PR :point_right:" label was removed as per ITA23.