search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
285 stars 63 forks source link

Modules needed for azd #261

Open jongio opened 8 months ago

jongio commented 8 months ago

It would be nice to move azd to use avm.

That would mean replacing our infra/core with avm.

bicep: https://github.com/Azure/azure-dev/tree/main/templates/common/infra/bicep tf: https://github.com/Azure/azure-dev/tree/main/templates/common/infra/terraform/core

Here are the needed resources: APIM Azure Development Environments Cosmos Mongo Cosmos SQL Postgres flexibleServers Sql Azure/Azure-Verified-Modules#43 AKS app service Azure/Azure-Verified-Modules#172 app service plan container apps / environment Azure/Azure-Verified-Modules#128 container registry Azure/Azure-Verified-Modules#38 functions static web app app insights log analytics Azure/Azure-Verified-Modules#121 cdn search role assignment storage account load testing

puicchan commented 8 months ago

Added ADE in above list.

jongio commented 8 months ago

Related to Cosmos: https://github.com/Azure/bicep-registry-modules/issues/632

jongio commented 8 months ago

Cosmos module needs "endpoints" output, which maps to cosmos.properties.documentEndpoint

mbilalamjad commented 8 months ago

@jongio will there be any resource module proposals for terraform ?

jongio commented 8 months ago

@jongio will there be any resource module proposals for terraform ?

All of the terraform modules we use are listed here: https://github.com/Azure/azure-dev/tree/main/templates/common/infra/terraform/core

It would be good to start a similar effort to fully move azd to avm.

mbilalamjad commented 8 months ago

Thanks @jongio for your response, just reviewed and extracted the below list for Terraform

For the ones mentioned as "Available in AVM", please feel free to review and provide feedback if you find any gaps with what there is correspondingly in AZD.

For the ones mentioned as "In Development in AVM", please feel free to reach out to the module owner/proposer, I'm sure they'll appreciate a hand especially if they can leverage what we have in AZD to accelerate the development of the module, you could potentially co-own the module with them.

For the ones mentioned as "Can be proposed in AVM", please feel free to propose and port them over from AZD to AVM. You can propose here https://github.com/Azure/Azure-Verified-Modules/issues/new/choose

CC: @PmeshramPM, @matt-FFFFFF, @jtracey93

mbilalamjad commented 7 months ago

@matebarabas @PmeshramPM guys given that the required AZD modules proposals have been created for bicep and terraform modules, can this issue be closed now or is there any further action needed before this issue could be closed

PmeshramPM commented 7 months ago

@mbilalamjad - Yes, from my side. Could you check with the requestor please

matebarabas commented 7 months ago

I also think this tracker achieved its goals. Even after closing it, this issue can still be used to get an overview on the state of the module development (i.e., as the issues are being closed).

@jongio, would you agree with us?

jongio commented 7 months ago

I'd say close it when the modules are available and azd is using them and retired the azd modules in favor of avm.

matebarabas commented 7 months ago

Alright, in this case I'll add the long-term label, so that the GH bot doesn't close the issue ahead of time. :)

kewalaka commented 3 months ago

function apps for terraform are now covered by these two:

https://github.com/Azure/terraform-azurerm-avm-res-web-serverfarm (i.e. app service plans) https://github.com/Azure/terraform-azurerm-avm-res-web-site

kristenwomack commented 1 month ago

Do we have any updates on progress of these modules for azd?