search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
349 stars 83 forks source link

[Module Proposal]: `avm-res-dbforpostgresql-flexibleserver` (tf) #273

Closed timchapman closed 1 month ago

timchapman commented 1 year ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-dbforpostgresql-flexibleserver

Module Details

Module for deploying an Azure PostgreSQL Flexible Server

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

timchapman

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

mbilalamjad commented 12 months ago

Hi @timchapman,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.
mbilalamjad commented 12 months ago

@timchapman please note that I've updated the name per the following spec, hope that makes sense https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-rmnfr1---category-naming---module-naming

timchapman commented 11 months ago

Hi @timchapman,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

mbilalamjad commented 11 months ago

Hi @timchapman,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

We just want to ask you to double check a few important things and take the next steps before you start the development.

Please use the following values explicitly as provided in the module index page:

Grant the right level of permissions for the AVM core team and PG teams on your GitHub repo as described here.

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR if available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.
mbilalamjad commented 9 months ago

Reached out to @timchapman offline, this proposal will be updated accordingly here based on his input.

mbilalamjad commented 8 months ago

Reached out to @timchapman offline to check-in on any updates or support needed, he or I will update accordingly.

v-xuto commented 8 months ago

Related to issue: https://github.com/Azure/Azure-Verified-Modules/issues/261 CC: @jongio

v-xuto commented 7 months ago

@timchapman - Do you have an ETA for this?

kewalaka commented 5 months ago

https://github.com/kewalaka/terraform-azurerm-avm-res-dbforpostgresql-flexibleserver

this covers the server & the database resources, needs a little love to add things like the entra admin & firewall rules children.

I'll probably get to it at some point, but anyone reading this - help much appreciated.

helps with #261

v-xuto commented 5 months ago

@timchapman - Do you have an ETA for this?

marcingastol commented 2 months ago

@kewalaka @timchapman I'd like to volunteer to contribute to this module. Let me know what should be my next steps? thanks.

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

alefteris commented 1 month ago

@mbilalamjad Is a process missing for reassigning a module to a different person, when the original person is not responding?

It's been almost a year since the original person @timchapman accepted to be the owner of the module and since then, there has not been a single reply from them (at least publicly here, not sure if you communicate internally at MS).

Since then, two different people expressed interest to take ownership of the module (@marcingastol, @cmaclaughlin) and also another person (@kewalaka) published an initial implementation of the module already, but with no way to progress the module in a road to be published officially, since it's being blocked by the original module owner assignment.

The resource that this module implements is, by my impression at least, a very used one and also it's blocking the azd migration to avm, as I understand.

kewalaka commented 1 month ago

happy to assist here, but as I'm not a MSFT'er I am not allowed to be the owner.

It's been a little while since I touched my implementation but it shouldn't take much to align to changes in spec.

mbilalamjad commented 1 month ago

Hey everyone, I've had a discussion with the original module owner and I'm taking over in the interim to help get this module out. I've reviewed what @kewalaka has shared above and added my contribution on top of it to align it with all updated AVM specs and checks into the below repo, please review and share feedback in terms of issues & PRs on the below repo https://github.com/Azure/terraform-azurerm-avm-res-dbforpostgresql-flexibleserver CC: @kewalaka, @marcingastol, @cmaclaughlin, @alefteris