Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
353 stars 83 forks source link

[Module Proposal]: `avm/res/event-grid/topic` #316

Closed fabmas closed 11 months ago

fabmas commented 12 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/event-grid/topic

Module Details

Migrate from CARML to AVM

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

fabmas

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

matebarabas commented 11 months ago

Hi @fabmas,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.
matebarabas commented 11 months ago

@fabmas, Please note that I updated the module name in the issue description, as it wasn't aligned with the new-old naming convention (the one used in the title of this issue).

fabmas commented 11 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 11 months ago

Hi @fabmas,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

We just want to ask you to double check a few important things and take the next steps before you start the development.

Please use the following values explicitly as provided in the module index page:

Grant the right level of permissions for the AVM core team and PG teams on your GitHub repo as described here.

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR if available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team


NOTE:

  • This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
  • Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.
matebarabas commented 11 months ago

Migrated from CARML by @fabmas - PR in review: https://github.com/Azure/bicep-registry-modules/pull/652

@fabmas, for future modules, please leave a message in the comment section with a link to the PR and mention the person who helped with the initial triage process. Thanks!

matebarabas commented 11 months ago

PR merged.

GitHub teams to be created:

@fabmas, please let me know once you've created these teams, as I will then need to add them to the corresponding parent team, which then you'll need to approve. Thanks.

matebarabas commented 11 months ago

Thank you for your work @fabmas! I'm closing this issue now.