Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
322 stars 68 forks source link

[Module Proposal]: `avm-res-eventhub-namespace` #367

Open kewalaka opened 9 months ago

kewalaka commented 9 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-eventhub-namespace

Module Details

This would be the Terraform module for the Event Hub namespace & child resources, such as Event Hub itself.

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

mbilalamjad

(Optional) Secondary Module Owner's GitHub Username (handle)

kewalaka

kewalaka commented 9 months ago

yeh.. you guessed it, there's a starter available here 😂🚀

https://github.com/kewalaka/terraform-azurerm-avm-res-eventhub-namespace

just the namespace resource & a starter on the event hub child resource at the moment.

mbilalamjad commented 9 months ago

@matebarabas I'm happy to own this and work with @kewalaka on it, could you please do the official handshake process

matebarabas commented 9 months ago

Hi @mbilalamjad,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

mbilalamjad commented 9 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 9 months ago

Hi @mbilalamjad,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

mbilalamjad commented 9 months ago

Thanks @matebarabas, will get started on the internal process of setting up the repo which should be ready by the time I return from holidays in the first week of Jan and then work with @kewalaka accordingly in getting this module published.

mbilalamjad commented 8 months ago

Hey @kewalaka, I've created the official repo, it's under review currently and will be public soon, will keep you posted, in the meantime I'll do a review of the module in your repo next week.

https://github.com/Azure/terraform-azurerm-avm-res-eventhub-namespace

mbilalamjad commented 7 months ago

Hey @kewalaka, hope you're doing great, getting back with an update, the repo setup is complete and public now, I've created a dev branch and added you as contributor to it https://github.com/Azure/terraform-azurerm-avm-res-eventhub-namespace

matt-FFFFFF commented 7 months ago

Hey @mbilalamjad

The repo permissions aren't correct, the Azure groups need to be granted admin rights as per the spec. Can you sort please?

kewalaka commented 7 months ago

hi @mbilalamjad the invite says this when i try click it "This invitation is invalid":

image

I'd tried it both from the email and the github portal, but in the meantime the following will land the code from my repo to Azure:dev

https://github.com/Azure/terraform-azurerm-avm-res-eventhub-namespace/pull/1

mbilalamjad commented 7 months ago

Hey @mbilalamjad Bilal Amjad FTE

The repo permissions aren't correct, the Azure groups need to be granted admin rights as per the spec. Can you sort please?

Thanks Matt, have fixed it

mbilalamjad commented 7 months ago

hi @mbilalamjad Bilal Amjad FTE the invite says this when i try click it "This invitation is invalid":

image

I'd tried it both from the email and the github portal, but in the meantime the following will land the code from my repo to Azure:dev

Azure/terraform-azurerm-avm-res-eventhub-namespace#1

Thanks @kewalaka will look into this.

kewalaka commented 7 months ago

@mbilalamjad I think dev is ready to be merged into main, but I'm not a collaborator so I can't raise the PR.

I seem to be having some issues running grept, not sure why, but I think all changes that it requires are in place.

can you raise the PR from azure:dev to azure:main please?

mbilalamjad commented 6 months ago

@mbilalamjad Bilal Amjad FTE I think dev is ready to be merged into main, but I'm not a collaborator so I can't raise the PR.

I seem to be having some issues running grept, not sure why, but I think all changes that it requires are in place.

can you raise the PR from azure:dev to azure:main please?

Hey Stu, will get in touch on this later this week, thank you for your patience.

microsoft-github-policy-service[bot] commented 5 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[!NOTE] This message was posted as per ITA24.

microsoft-github-policy-service[bot] commented 5 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[!NOTE] This message was posted as per ITA24.

mbilalamjad commented 4 months ago

@kewalaka getting back to you on this, I raised the PR from dev to main and merged it, also ran grept and merged a PR from it, have a look and let me how things look

microsoft-github-policy-service[bot] commented 4 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[!NOTE] This message was posted as per ITA24.

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[!NOTE] This message was posted as per ITA24.

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 1 week ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.