search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
350 stars 83 forks source link

[Module Proposal]: `avm-res-network-applicationgateway` #41

Closed PmeshramPM closed 2 months ago

PmeshramPM commented 1 year ago

Check for previous/existing GitHub issues/module proposals

Terraform or Bicep?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-network-applicationgateway

Module Details

GH repo name - terraform-azurerm-avm-res-network-applicationgateway

Application Gateway is one of the most common requirement for Internet facing applications to manage the web traffic.

Please refer to the this CARML Bicep module as it already implements RBAC, Locks, Tags, and Diag. https://github.com/Azure/ResourceModules/tree/main/modules/network/application-gateway

Do you want to be the owner of this module?

No

Module Owner's GitHub Username

No response

PmeshramPM commented 1 year ago

@mofaizal - Please see that the ask here is to build two modules. Please see the details here https://azure.github.io/Azure-Verified-Modules/indexes/terraform/tf-resource-modules/

  1. avm-res-network-applicationgateway - deploying the app gateway
  2. avm-res-network-applicationgatewaywebapplicationfirewallpolicy - WAF policies

We have the same reference in Bicep registry and keen to keep that consistent with TF.

Please do let me know if you are happy with this and any thoughts.

PmeshramPM commented 1 year ago

Hi @mofaizal - Please pay attention to the module name description and GH repo name above. Updated that based on specs.

JefferyMitchell commented 11 months ago

@mofaizal Any update?

mbilalamjad commented 11 months ago

Tagging @matt-FFFFFF as he is going to be reviewing this module before its published into the terraform registry

PmeshramPM commented 10 months ago

@mofaizal is meeting with @matt-FFFFFF this week to get the feedback after module review and then work on the feedback.

JefferyMitchell commented 10 months ago

@mofaizal @PmeshramPM Please let me know when ready for AG PG Team review and I will forward the monthly meeting or schedule a one off meeting.

CC: @matt-FFFFFF

mbilalamjad commented 9 months ago

Reached out to @mofaizal offline, proposal will be updated here based on his input accordingly.

mbilalamjad commented 8 months ago

Reached out to @mofaizal and team offline to check-in on any updates or support needed from the AVM team, he or I will update here accordingly

mofaizal commented 8 months ago

Thanks for the follow up the In development

kewalaka commented 8 months ago

@mofaizal I'm interested in using this module. Can you share current state so I can help get this ready for v0.1 please?

I've got a few AVMs contributed so I may be able to help get this to done.

mofaizal commented 8 months ago

@kewalaka Thank you for the interested in using this module, I got few feedback from @matt-FFFFFF planning to work this week. Once done will ping you for testing and feedback.

mofaizal commented 7 months ago

Testing in progress, for

The following in development

mofaizal commented 6 months ago

@mbilalamjad @matt-FFFFFF @Azure/avm-core-team looking forward your feedback to publish the module. Thanks

mbilalamjad commented 6 months ago

@mbilalamjad @matt-FFFFFF @Azure/avm-core-team looking forward your feedback to publish the module. Thanks

Hey @mofaizal, will do a review and update this week accordingly.

mbilalamjad commented 6 months ago

Hey @mofaizal, kindly perform the "Requested Actions" in the AVM-Review of the module, feel free to reach out if you have any questions or need any support.

JefferyMitchell commented 6 months ago

@mbilalamjad What are the next steps?

mbilalamjad commented 5 months ago

@mbilalamjad What are the next steps?

Per my above comment, @mofaizal to do the "Requested Actions" to complete the module review.

kewalaka commented 5 months ago

@mofaizal if you'd like to invite me as a contributor I'm happy to help complete the review tasks or help with any areas you need guidance on.

mofaizal commented 5 months ago

@kewalaka thanks for offering help. The code is completed, and review also done. There is issue with avmtest, understand from @mbilalamjad that there's been some problem with the runners the team trying to address it.

kewalaka commented 5 months ago

@mofaizal thanks for the update - is the azurerm_web_application_firewall_policy resource included in the module, or is that needed separately?

mofaizal commented 4 months ago

Thanks for the follow up, @mbilalamjad any update on my repo mainly on AVM check the Destroy complete!

TestExample/simple_http_route_by_url_app_gateway 2024-05-29T05:44:06Z command.go:185: Destroy complete! Resources: 13 destroyed. Error: Process completed with exit code 2.

Due to above error unable to merge to make it public :-( i need to help from core team

kewalaka commented 4 months ago

@mofaizal if you invite me as a contributor I can take a look for you, if you like. I've been across helping with several AVMs so this isn't breaking ground 😄

matt-FFFFFF commented 4 months ago

Hi @mofaizal

Consider releasing this on the registry as a 0.1.0 to get initial feedback, even with the destroy error I think it's be good to see this land.

Thanks for all your efforts!

mbilalamjad commented 4 months ago

Hi @mofaizal

Consider releasing this on the registry as a 0.1.0 to get initial feedback, even with the destroy error I think it's be good to see this land.

Thanks for all your efforts!

@matt-FFFFFF, @mofaizal the linting / terraform check is failing with 33 issues, would recommend we address those first and complete the AVM-Review before publishing

matt-FFFFFF commented 4 months ago

We released a new version of the container that should properly print the errors now

mofaizal commented 3 months ago

Thanks @matt-FFFFFF back from leave, will check and update the status here.

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

mbilalamjad commented 2 months ago

The initial review of this module is complete, and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index. Terraform Registry Link: https://registry.terraform.io/modules/Azure/avm-res-network-applicationgateway/azurerm/latest GitHub Repo Link: https://github.com/Azure/terraform-azurerm-avm-res-network-applicationgateway