search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
349 stars 83 forks source link

[Orphaned Module]: `avm/res/data-factory/factory` #431

Closed matebarabas closed 8 months ago

matebarabas commented 10 months ago

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/data-factory/factory

Module Details

This module was migrated from CARML by @krbar without an owner.

Note: when someone volunteers to be the owner of this module, please reach out to @krbar to for changing the ownership of the existing GitHub teams as well.

Do you want to be the new owner of this module?

No

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

jikuja commented 10 months ago

As soon as this module has owner discussions to make template fully re-deployable should be started with PG.

Not sure if support ever contacted PG about those.

matebarabas commented 10 months ago

@jeanchg, once we have an owner, please help identify who would be the DRI for this module. Thanks!

clintgrove commented 9 months ago

Hi @matebarabas I can take on the ADF deployment bicep as owner

matebarabas commented 9 months ago

Hi @clintgrove,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

clintgrove commented 9 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 9 months ago

Hi @clintgrove,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

We just want to ask you to double check a few important things.

Please use the following values explicitly as provided in the module index page:

You can now take ownership of this module and start improving it as needed! ✅ Happy coding! 🎉

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

matebarabas commented 9 months ago

@clintgrove, since this module has been migrated by @krbar (Kris Baranek), he's created the required GH teams. Please work with him to take ownership over these teams and let me know in a comment here when it happened. Thanks!

krbar commented 8 months ago

@matebarabas FYI: the GitHub teams are transferred to @clintgrove

clintgrove commented 8 months ago

As soon as this module has owner discussions to make template fully re-deployable should be started with PG.

Not sure if support ever contacted PG about those.

My thoughts on this.

  1. Last commit idea - This should not be an issue if developers are following the recommended deployment practices by Microsoft. The new recommendations are found here, where it is suggested that the manual publishing of data factory is not necessary when doing a devops deployment. https://learn.microsoft.com/en-us/azure/data-factory/continuous-integration-delivery-improvements#continuous-deployment-improvements. If a developer or user is deploying infrastructure of the data factory through CI/CD and then using older methods of publishing manually from the data factory to the adf_publish branch and then grabbing that template to deploy then I can see how it would show that the resources need to be overwritten entirely. This seems to be a knowledge problem of best practice instead of a product bug.
  2. When Data Factory is deployed using infrastructure and there are no global parameters as a part of the infrastructure deployment then it will delete/reset the global parameters yes. CI/CD for data factory global parameters CAN be be done as a services deployment (normal practice) OR if you deploying infrastructure and you DO NOT want your global parameters to disappear (and for some reason you are not deploying the inner workings of your data factory using CI/CD) then you MUST include the global parameters in the infrastructure code - when calling the AVM module for data factory you would add a "resource" in your bicep to add global parameters (https://learn.microsoft.com/en-us/azure/templates/microsoft.datafactory/factories/globalparameters?pivots=deployment-language-bicep)
matebarabas commented 8 months ago

@matebarabas Mate Barabas FTE FYI: the GitHub teams are transferred to @clintgrove Clint Grove FTE

Thank you for confirming! As the ownership transfer of this module is now complete. I'm closing this issue now.

If any further questions, feature requests, etc. need to be raised for this module, please open a module issue here: https://aka.ms/AVM/Bicep/ModuleIssue