Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.

https://aka.ms/AVM

MIT License

349 stars 83 forks source link

[Module Proposal]: `avm-res-sql-server` #442

Closed kewalaka closed 1 month ago

kewalaka commented 10 months ago

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-sql-server

Module Details

This is for the Azure SQL Database resource, i.e. the Terraform equivalent of #322

I have a start on this module available here: https://github.com/kewalaka/terraform-azurerm-avm-res-sql-server - covering the parent SQL server resource, and two children (elastic pools & databases).

Looking for help to build out the additional child resources, create more validations, & add more E2E tests to the existing set.

Do you want to be the owner of this module?

Module Owner's GitHub Username (handle)

mbilalamjad

(Optional) Secondary Module Owner's GitHub Username (handle)

kewalaka

mbilalamjad commented 10 months ago

@matebarabas I'm happy to work with @kewalaka on this module, could you please help us with triaging this proposal

matebarabas commented 10 months ago

Hi @mbilalamjad,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

mbilalamjad commented 10 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 10 months ago

Hi @mbilalamjad ,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

For your module:
- ModuleName - for naming your module
- TelemetryIdPrefix - for your module's telemetry
For your module's repository:
- Repo name and folder path are defined in RepoURL
- Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
- Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

mbilalamjad commented 10 months ago

Thanks @matebarabas, will get started on the internal process of setting up the repo which should be ready by the time I return from holidays in the first week of Jan and then work with @kewalaka accordingly in getting this module published.

mbilalamjad commented 10 months ago

Hey @kewalaka, I've created the official repo, it's under review currently and will be public soon, will keep you posted, in the meantime I'll do a review of the module in your repo next week

https://github.com/Azure/terraform-azurerm-avm-res-sql-server

kewalaka commented 9 months ago

thanks @mbilalamjad - once it is available, what we've done with other AVM collaborations is to create a dev branch on the Azure repo.

External contributors can then create PRs against azure:dev, which can be PR'ed against azure:main without hitting the issues with the workload identity for the E2E tests, until the internal runners are available.

mbilalamjad commented 9 months ago

Update: Repo is still in review, will update here once repo setup is complete

microsoft-github-policy-service[bot] commented 9 months ago

@mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

kewalaka commented 8 months ago

hi @mbilalamjad just wondered if there is any word on the repo availability, please?

mbilalamjad commented 8 months ago

hi @mbilalamjad Bilal Amjad FTE just wondered if there is any word on the repo availability, please?

Hey @kewalaka, repo setup is finally complete, will be reaching out this week with details for us to get started, appreciate your patience

v-xuto commented 8 months ago

Related to issue: https://github.com/Azure/Azure-Verified-Modules/issues/261 CC: @jongio

kewalaka commented 8 months ago

@mbilalamjad any update on this please?

v-xuto commented 7 months ago

@mbilalamjad - Do you have an ETA for this?

mbilalamjad commented 7 months ago

Hey @kewalaka, hope you're doing great, apologies for the delay, getting back with an update, the repo setup is complete and public now and I've created a dev branch https://github.com/Azure/terraform-azurerm-avm-res-sql-server CC: @v-xuto

kewalaka commented 7 months ago

i've just raised a PR against the dev branch because the template version it was based on needs an update.

I've tagged Bilal in the PR https://github.com/Azure/terraform-azurerm-avm-res-sql-server/pull/4

I plan to fold in the SQL Server code from my repo after that - it's been a while since i wrote it so i'm anticipating some "re-alignment" work there too.

mbilalamjad commented 6 months ago

i've just raised a PR against the dev branch because the template version it was based on needs an update.

I've tagged Bilal in the PR Azure/terraform-azurerm-avm-res-sql-server#4

I plan to fold in the SQL Server code from my repo after that - it's been a while since i wrote it so i'm anticipating some "re-alignment" work there too.

Hey @kewalaka thank you, have merged your PR, feel free to push the SQL Server code from your repo and I'll review it accordingly.

microsoft-github-policy-service[bot] commented 6 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[!NOTE] This message was posted as per ITA24.

microsoft-github-policy-service[bot] commented 5 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[!NOTE] This message was posted as per ITA24.

microsoft-github-policy-service[bot] commented 4 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] @mbilalamjad, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.