search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
321 stars 68 forks source link

[Module Proposal]: `avm-ptn-aks-production`(tf) #518

Closed zioproto closed 4 months ago

zioproto commented 8 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

I'm not sure, please advise

Module Name

avm-ptn-aks-production

Module Details

This is the original comprehensive AKS Verified Module, including 100+ properties and giving users the freedom to configurate their files with their exact specifications: https://github.com/Azure/terraform-azurerm-aks. These configuration options are incredibly comprehensive, encompassing every facet of AKS configuration. However, this design may pose challenges for individuals who prefer streamlined options or lack extensive AKS background knowledge. To ensure seamless experience for all users and to keep pace with the growing AKS Azure user base, we want to launch several simplified versions of the AKS module. These streamlined versions will feature default settings for certain complex configurations, mirroring the user-friendly design in the Azure Portal.

We will categorize the AKS modules based on the cluster preset configuration settings. This approach is essential as modules are significantly impacted by these configurations, influencing resource allocation, scalability, cost, compatibility, networking, security, and various other aspects.

The first simplified AKS module we want to release is the production standard module. (Simpler than the original comprehensive AKS module, but still suitable for most business scenarios).

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

zioproto

(Optional) Secondary Module Owner's GitHub Username (handle)

Jingwei-MS

mbilalamjad commented 7 months ago

@matt-FFFFFF, @lonegunmanb interested in your feedback based on the equivalent TFVM module for AKS how we should handle these two module proposals

nellyk commented 7 months ago

@mbilalamjad To add to our initial description as per our discussion in the office hours we are going ahead with with creating a pattern module which will have the above setup for AKS + ACR.

Would it be possible to help us with the naming for the pattern module?

mbilalamjad commented 7 months ago

Hi @zioproto,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

mbilalamjad commented 7 months ago

@mbilalamjad Bilal Amjad FTE To add to our initial description as per our discussion in the office hours we are going ahead with with creating a pattern module which will have the above setup for AKS + ACR.

Would it be possible to help us with the naming for the pattern module?

@nellyk had a discussion with the team and updated the name to suggested, let me know if that makes sense

zioproto commented 7 months ago

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

mbilalamjad commented 7 months ago

Hi @zioproto,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

We just want to ask you to double check a few important things.

Please use the following values explicitly as provided in the module index page:

You can now take ownership of this module and start improving it as needed! ✅ Happy coding! 🎉

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

microsoft-github-policy-service[bot] commented 6 months ago

@zioproto, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

mbilalamjad commented 6 months ago

Requested @zioproto to share an update here.

zioproto commented 6 months ago

The module is currently in development:

@nellyk is actively working on these 3 PRs:

@nellyk do you agree after those 3 are merged we could release a first preview version ? Thanks

nellyk commented 6 months ago

@mbilalamjad Wanted to provide an update

@zioproto made changes and the above have been merged.

We have a pending item with the network configuration since we would like users to supply a VNet that requires a subnet for the natgateway and a natgateway to be created. We are exploring options for this so that it is less complicated for users

microsoft-github-policy-service[bot] commented 5 months ago

[!IMPORTANT] @zioproto, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[!NOTE] This message was posted as per ITA24.

nellyk commented 5 months ago

@mbilalamjad i think we can close this now as the module has been released https://registry.terraform.io/modules/Azure/avm-ptn-aks-production/azurerm/latest

mbilalamjad commented 4 months ago

Thank you so much @nellyk & @zioproto for your contribution

Closing as module has been published to terraform registry below https://registry.terraform.io/modules/Azure/avm-ptn-aks-production/azurerm/latest

Further discussion on this module including issues & PRs to take please on its repo below https://github.com/Azure/terraform-azurerm-avm-ptn-aks-production