search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
333 stars 71 forks source link

[Module Proposal]: `avm-res-datafactory-factory` (tf) #526

Open PmeshramPM opened 8 months ago

PmeshramPM commented 8 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-datafactory-factory

Module Details

AVM Resource module for Data Factory

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

asishr14 commented 8 months ago

I would like to take ownership for this

mbilalamjad commented 8 months ago

Hi @asishr14,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

asishr14 commented 8 months ago

Hi, I agree and confirm all the pages described. However, I would like to have a collaborator for the Bicep Module. Please let me know if that is possible.

On Fri, Jan 26, 2024 at 9:27 PM Bilal Amjad @.***> wrote:

Hi @asishr14 https://github.com/asishr14,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

— Reply to this email directly, view it on GitHub https://github.com/Azure/Azure-Verified-Modules/issues/526#issuecomment-1912920534, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADA5RB6763CXD4GOHLKH3JLYQRQ2ZAVCNFSM6AAAAABB4T7EOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSHEZDANJTGQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Thank you, Asish R.

Karni-G commented 8 months ago

Hello - I'm interested in the development of this module via Terraform as an owner. Thanks!

PmeshramPM commented 8 months ago

Hi @Karni-G,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

PmeshramPM commented 8 months ago

@asishr14 - I see you are requesting for Bicep one. Could you please check the looking for owners section(https://github.com/orgs/Azure/projects/529) ? This one is specifically for TF. Also if you do not see in the list, you can propose one.

asishr14 commented 8 months ago

@PmeshramPM : Sorry for the confusion. I am requesting for the TF module only. As the document (Shared Specification (Bicep & Terraform)) to accept for both TF & Bicep, I wanted to confirm that i will be only owning TF and NOT the Bicep.

mbilalamjad commented 8 months ago

Hi @asishr14,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

mbilalamjad commented 8 months ago

@PmeshramPM Pankaj Meshram FTE : Sorry for the confusion. I am requesting for the TF module only. As the document (Shared Specification (Bicep & Terraform)) to accept for both TF & Bicep, I wanted to confirm that i will be only owning TF and NOT the Bicep.

Yes, this will only be for TF, you don't necessarily need to develop and own the Bicep equivalent unless you want to.

mbilalamjad commented 8 months ago

Hello - I'm interested in the development of this module via Terraform as an owner. Thanks!

@Karni-G since @asishr14 reached out first so we've assigned him as the owner, you can work with them as co-owner and contributor on this module if you'd like to and @asishr14 is ok with that

asishr14 commented 8 months ago

Hello - I'm interested in the development of this module via Terraform as an owner. Thanks!

@Karni-G since @asishr14 reached out first so we've assigned him as the owner, you can work with them as co-owner and contributor on this module if you'd like to and @asishr14 is ok with that

@Karni-G open to collaborate. Please feel free to reach out.

Karni-G commented 8 months ago

Hello - I'm interested in the development of this module via Terraform as an owner. Thanks!

@Karni-G since @asishr14 reached out first so we've assigned him as the owner, you can work with them as co-owner and contributor on this module if you'd like to and @asishr14 is ok with that

@Karni-G open to collaborate. Please feel free to reach out.

Will contact you Asish

asishr14 commented 7 months ago

@mbilalamjad : i created a separate repo for the module from the template and working on it over there, is there anything i need to do on this issue?

mbilalamjad commented 7 months ago

Hey @asishr14, sounds good, just if you could leave an update here, could be as detailed or as short as you like, this would make the bot happy, and I can remove the needs attention label from it which gets added after 3 weeks of inactivity on the module proposal till the module is published into the Hashi Corp registry and this proposal is closed at that time.

asishr14 commented 7 months ago

Hey @mbilalamjad, i would like to update the module ownership to my work git account where i have access to Azure Org, so i will be contributing from that account only. Here is my work git ID - @asishr .

mbilalamjad commented 6 months ago

Hey @mbilalamjad Bilal Amjad FTE, i would like to update the module ownership to my work git account where i have access to Azure Org, so i will be contributing from that account only. Here is my work git ID - @asishr Asish Racha FTE .

Requesting @prjelesi to advise on this change

prjelesi commented 6 months ago

HI @asishr,

please proceed with development, I will update index page.

asishr14 commented 5 months ago

Repo created and first commit added.

matebarabas commented 1 month ago

Repo created and first commit added.

@asishr14, can you please provide a link to the repository? It's supposed to be created with this URL: https://github.com/Azure/terraform-azurerm-avm-res-datafactory-factory but this doesn't exist. Thanks!

asishr commented 1 month ago

Hi, The repo I created with that name, got archived and I didn't got a chance to work on it. Let me know if there's anything else I can share.On Aug 12, 2024 12:51, Máté Barabás @.> wrote:Repo created and first commit @., can you please provide a link to the repository? It's supposed to be created with this URL: https://github.com/Azure/terraform-azurerm-avm-res-datafactory-factory but this doesn't exist. Thanks!—Reply to this email directly, view it on GitHub or unsubscribe.You are receiving this email because you were assigned.Triage notifications on the go with GitHub Mobile for iOS or Android.                                                           

asishr14 commented 3 weeks ago

Repo unarchived

asishr14 commented 1 week ago

Changes updated to forked repo