Open khushal08 opened 8 months ago
Hi @khushal08,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:
Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER
Hi @khushal08,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:
ModuleName
- for naming your moduleTelemetryIdPrefix
- for your module's telemetryCheck if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team
@khushal08 - if you need assistance, happy to collaborate
Reached out to @khushal08, he or I will come back with an update
In development.
@khushal08 just a FYI, Express route circuits seemed to be covered by the below pattern module, would recommend re-evaluating if this resource module is needed or does the below pattern module suffice https://registry.terraform.io/modules/Azure/avm-ptn-vnetgateway/azurerm/latest
Hi @khushal08 please continue to work on this as resource module.
@prjelesi / @khushal08 - sorry I commented on this thread by accident, when I clearly meant to comment on the Route Table task :O However, verry happy to help with this module development if required!
ExpressRoute Circuit module is ready to be published to terraform registry. We have tested it on our internal subscription with ER access. Here is PR link - https://github.com/Azure/terraform-azurerm-avm-res-network-expressroutecircuit/pull/24
@Azure/avm-core-team @mbilalamjad @prjelesi @matt-FFFFFF @jaredfholgate Can you please help review?
CC: @adammontlake
I have completed my initial development of the module and I would like to request a review of my module before publishing it to the terraform registry. The latest code is in a PR titled AVM-Review-PR on the module repo and all checks on that PR are passing.
Check for previous/existing GitHub issues/module proposals
Check this module doesn't already exist in the module indexes
Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-network-expressroutecircuit
Module Details
Terraform AVM module for expressroute circuit.
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
khushal08
(Optional) Secondary Module Owner's GitHub Username (handle)
No response