search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
348 stars 82 forks source link

[Module Proposal]: `Logic Apps Standard` #647

Open scottroot-msft opened 8 months ago

scottroot-msft commented 8 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/website/logic-app-standard

Module Details

I discussed this with Lohith and some other folks from the AVM chat we had yesterday.

Currently there is a logic apps module (consumption). There is no specific module for Logic Apps standard.

I am told to use the Website module and specify the 'kind' parameters to include workflowapp etc. accordingly. Not a problem.

In discussing this with Lohith, he wanted me to submit this as an issue for community discussion to see if it made sense to have a module that was just 'preconfigured' with the kind attribute or not. There also is no example for logic app standard on the website module, so that could be an option as well.

I know that there is a dependency on an app service plan, and that for logic apps only the WS* plans are supported, so this may also be worth discussing.

Thanks for considering logic apps standard.

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

lohithgn commented 8 months ago

@matebarabas @PmeshramPM can you folks check this one. As @scottroot-msft said - i like the idea of having a dedicated resource module called Logic App Standard. All the nuances of how this to be set up (i.e. this is a website underneath, with a specific plan which is of type WorkflowStandard-1/2/3) can be in this resource module. We i.e. MS have been asking cx to move to LA Standard from LA ISE - coz ISE is getting retired on Aug 2024.

thoughts?

matebarabas commented 8 months ago

Based on our internal discussion, @lohithgn will further clarify this proposal with @scottroot-msft and will assess if this request is best positioned as a feature request for the existing module of avm/res/web/site (in which case this issue will be closed), or as a pattern module (in which case this issue will need to be updated with a new the module name and pattern module classification).

frasermolyneux commented 6 months ago

Has the discussion been held? I would be interested in either working on a new resource or helping to extend the existing - happy to discuss internally if needed.

scottroot-msft commented 6 months ago

Has the discussion been held? I would be interested in either working on a new resource or helping to extend the existing - happy to discuss internally if needed.

@lohithgn and I did discuss a while back and it was communicated to me that a logic apps standard AVM would be better suited in the patterns module. Is this still the case @lohithgn ?

lohithgn commented 6 months ago

@scottroot-msft Yes. If we need lets say a logic-app module - it will have to be a pattern module. @matebarabas what needs to be done to turn this issue/proposal to a pattern module request?

matebarabas commented 6 months ago

@lohithgn, @scottroot-msft, I've just reached out to you internally with some clarifying questions.