Open kpantos opened 8 months ago
@kpantos, thank you for proposing this module! As this is categorized as a pattern module, its approval will require a more thorough assessment. The AVM core team will get back to you soon. Thank you for your patience!
@matebarabas why is this proposal at looking for owner state? I've already selected that I want to own the pattern module.
@kpantos, I'll reach out to you internally regarding this proposal and the other 2 that you filed along with it.
To your question: I'm not sure why @eriqua has changed the status of this, but we'll properly administer everything on this issue once we aligned internally.
My bad @kpantos, that was definitely unintended.
This module will take a dependency on https://github.com/Azure/Azure-Verified-Modules/issues/604.
Hi @kpantos,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:
Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER
Hi @kpantos,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:
ModuleName
- for naming your moduleTelemetryIdPrefix
- for your module's telemetryCheck if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team
@kpantos, thanks again for proposing this module! Please don't forget to add the discussed details to the description, including the architectural diagram, and bill of materials. Thanks!
@kpantos, I just pinged you internally regarding the inactivity on this module's development. Please let me know how you're planning to proceed. Thanks!
@matebarabas after having several internal alignment discussions with the whole Tech Strategy team we need to change the naming of the proposed pattern module from avm/ptn/aca-lza/data-services to avm/ptn/lza/data-services, as this module is going to be common across all our LZAs products and not just the aca one. Can you please assist us on how to go about this?
As agreed, this module will be renamed from avm/ptn/aca-lza/data-services
to avm/ptn/lza-shared/data-services
. This way, smaller sections of more complex LZA modules that can be reused across multiple LZA pattern modules can be placed into the lza-shared
folder.
Steps for renaming this module:
Note: these don't necessarily have to be performed in this exact order, but all of them need to be confirmed before the code can be merged under the new name.
@kpantos, all requirements listed above are now complete.
Thank you @matebarabas really appreciate it. Will start working on this asap.
Check for previous/existing GitHub issues/module proposals
Check this module doesn't already exist in the module indexes
Bicep or Terraform?
Bicep
Module Classification?
Pattern Module
Module Name
avm/ptn/lza-shared/data-services
Module Details
This LZA data-services pattern module represents a common data services deployment for a LZA architecture aligned with the cloud adoption framework implementing industry proven practices, such as those presented in Azure landing zones guidance in the Cloud Adoption Framework, owned and operated by a workload team. This data-services pattern module deploys several commonly used Azure data services for all the LZA pattern modules.
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
kpantos
(Optional) Secondary Module Owner's GitHub Username (handle)
No response