[Module Proposal]: `avm/res/service-networking/traffic-controller`

[shailwx]

Check for previous/existing GitHub issues/module proposals

• [X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

• [X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/service-networking/traffic-controller

Module Details

A bicep module for application gateway for containers

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

shailwx

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

[matebarabas]

@shailwx, thank you for proposing this module! In line with @mbilalamjad's comments on the sister issue, I'd like to ask the following questions:

• This module seems already in development - avm/res/network/application-gateway. Could you please have a look and confirm if this is what you intended to propose?
• In case you believe your use case is different, can you please elaborate on your requirements? Please note that in case another module (whether resource or pattern module) needs to be developed, we'll need to find a Microsoft FTE to own the module, since this is a requirement for AVM. As your GitHub handle doesn't seem to be assigned with a Microsoft corporate account, I'm assuming you're not an FTE. In case you are one, you can link your account here: https://aka.ms/LinkYourGitHubAccount (this works for FTEs only).

[shailwx]

Hi @matebarabas,

• Application Gateway and Application Gateway for containers are two different products from same family of load balancing products.
• No I am not a Microsoft FTE.

[matebarabas]

@shailwx, apologies for the confusion and thanks for the clarification!

I can see that in case of this resource, we're talking about the following resource provider and resource type Microsoft.ServiceNetworking/trafficControllers. According to this, I've updated the issue's name and description to avm/res/service-networking/traffic-controller.

This module would also need to cater for the child resources of this parent resource:

• Microsoft.ServiceNetworking/trafficControllers/Frontends
• Microsoft.ServiceNetworking/trafficControllers/Associations

Please note that:

• the Bicep/ARM template reference doesn't seem to be available for this service just yet,
• the API reference for the 2023-05-01-preview version (only this preview version is available) can be accessed here: TrafficController - Create Or Update,
• based on the AVM requirement documented in SFR1, certain restrictions may apply when the service is in preview or only has a preview API available.

Please allow some time for the AVM core team (@Azure/avm-core-team-technical-bicep) to thoroughly assess this situation with this proposal. Thank you for your patience!

Thanks for confirming you're not a Microsoft FTE! If/when this proposal gets admitted, we will try to find a module owner you can work with as a contributor. We highly appreciate your help!

CC: @mbilalamjad

[matebarabas]

@shailwx, thank you for your patience! The AVM Core Team has triaged this proposal and approved it for development as a resource module.

The next step is to identify a Microsoft FTE, who could be the module owner. Since you originally indicated you'd like to own this module (which unfortunately is not possible today, as only FTEs can be owners), I'm assuming you'd like to actively contribute to the development, testing, publication and perhaps maintenance of this module. Is my assumption correct?

I also would like to ask if by any chance you know and/or have worked with any of our existing AVM module owners. I'm only asking this, as if this was the case, we'd continue by asking that person, if they'd be interested in working with you as an external contributor. If you don't know any of the existing AVM module owners, there's still no need to worry, as we'll try to identify someone who could work with you. For time zone level proximity, could you please confirm that you're working based out of CET?

Thank you!

[shailwx]

@matebarabas, Thanks for the update. Thanks for accepting the proposal for the development of the module

Yes, I would like to actively contribute to the development, testing, publication and perhaps maintenance of this module. No, I am not worked with any AVM module owners so far. And yes I am based in CET.

Thank you so much :)

[krbar]

@matebarabas @shailwx Hello, I'm happy to be the admin owner and help with the dev and publication process for this module.

[matebarabas]

Thank you @krbar! I'll share the contact details of @shailwx with you internally, so you can set up a call with him. Until then, let's do a quick handshake on this issue!

[matebarabas]

Hi @krbar,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

• Team Definitions & RACI
• Shared Specification (Bicep & Terraform)
• Module Support

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

[krbar]

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

[matebarabas]

Hi @krbar,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

• For your module:
  • ModuleName - for naming your module
  • TelemetryIdPrefix - for your module's telemetry
• For your module's repository:
  • Repo name and folder path are defined in RepoURL
  • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
  • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

[krbar]

FYI: I reached internally someone from Azure Docs team and reported the missing template reference for Microsoft.ServiceNetworking/trafficControllers. He will add it to the backlog so I hope that we will have a documentation soon.

[shailwx]

Hi, @matebarabas Me and Kris have started working on this. We need some help from PG as we are missing some documentation on the APIs. We will resume our as soon as we get some feedback from PG

[krbar]

@shailwx The template reference for this module is now available. See https://learn.microsoft.com/en-us/azure/templates/microsoft.servicenetworking/trafficcontrollers?pivots=deployment-language-bicep

[microsoft-github-policy-service[bot]]

[!IMPORTANT] @krbar, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[microsoft-github-policy-service[bot]]

[!IMPORTANT] @krbar, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[krbar]

@shailwx any updates on the module creation progress?