Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
350 stars 83 forks source link

[Module Proposal]: `avm/ptn/app/container-job-toolkit` #754

Open ReneHezser opened 8 months ago

ReneHezser commented 8 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/app/container-job-toolkit

Module Details

It allows a single Docker container to be executed on a regular schedule.

For a customer project I had the simple job of “running a container daily”, which required much more effort to achieve than expected. That is why this pattern module creates needed resources, so the developer can “just deploy this simple container”. The goal of this module is to allow specifying as much as an image and a cron expression. It will import an existing image, with the option to rename that image.

Optionally, many resources can be passed in and used, as well as deploying everything with Private Endpoints.

I was looking for a straightforward way to deploy a container that runs on a daily schedule and could find one. That's why I think this pattern module brings benefits and makes it easy to run a container on a schedule in Azure.

What it should deploy:

What it will deploy if not passed in as resource ID:

What will be deployed with the option deployInVnet:

Image

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

ReneHezser

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

matebarabas commented 7 months ago

@ReneHezser, thank you for proposing this module! As this is categorized as a pattern module, its approval will require a more thorough assessment. The AVM core team will get back to you soon. Thank you for your patience!

matebarabas commented 1 month ago

Hi @ReneHezser,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

ReneHezser commented 1 month ago

I confirm I wish to own this AVM module and understand the requirements and definition of a module Owner

matebarabas commented 1 month ago

Hi @ReneHezser,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

microsoft-github-policy-service[bot] commented 3 weeks ago

[!IMPORTANT] @ReneHezser, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 5 days ago

[!IMPORTANT] @ReneHezser, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

ReneHezser commented 4 days ago

Waiting for merge

matebarabas commented 14 hours ago

Thanks for your work, @ReneHezser! Please always provide a link to the PR, when available: https://github.com/Azure/bicep-registry-modules/pull/3352 👍 Thanks!