Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
352 stars 83 forks source link

[Module Proposal]: `avm/ptn/deployment-script/create-kv-ssh-key-pair` #764

Open vlahane opened 7 months ago

vlahane commented 7 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/ptn/deployment-script/create-kv-ssh-key-pair

Module Details

Why is the module needed? When creating Virtual Machines in Azure one option for authentication is to use a SSH key pair. In this scenario, the user has to locally generate and provide the public key. This creates friction for scenarios where a SSH key is needed;

If the user does not have the correct local tooling If the user does not have familiarity on how to correctly create the key. Module path deployment-scripts/create-kv-sshkeypair

Describe the module. Takes a Key Vault name, and secret names (for the public/private parts) and uses a bash script with ssh-keygen to create a ssh key pair and then store it in the existing Azure Key Vault.

note: this is existing module from: https://github.com/Azure/bicep-registry-modules/tree/main/modules/deployment-scripts/create-kv-sshkeypair which will be migrated to AVM.

[Update] - Here's the latest version published: https://github.com/Azure/bicep-registry-modules/tree/deployment-scripts/create-kv-sshkeypair/1.0.2/modules/deployment-scripts/create-kv-sshkeypair

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

matebarabas commented 7 months ago

@vlahane, thank you for proposing this module! As this will most likely be categorized as a pattern module, its approval will require a more thorough assessment. The AVM core team will get back to you soon. Thank you for your patience!

matebarabas commented 7 months ago

Hi @vlahane,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

vlahane commented 7 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

microsoft-github-policy-service[bot] commented 7 months ago

[!NOTE] The "Needs: Author Feedback :ear:" label was removed and the "Needs: Attention :wave:" label was added as per ITA11.

matebarabas commented 7 months ago

Hi @vlahane,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

microsoft-github-policy-service[bot] commented 6 months ago

[!IMPORTANT] @vlahane, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[!NOTE] This message was posted as per ITA24.

microsoft-github-policy-service[bot] commented 6 months ago

[!IMPORTANT] @vlahane, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[!NOTE] This message was posted as per ITA24.

microsoft-github-policy-service[bot] commented 5 months ago

[!IMPORTANT] @vlahane, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

[!NOTE] This message was posted as per ITA24.

microsoft-github-policy-service[bot] commented 4 months ago

[!IMPORTANT] @vlahane, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 4 months ago

[!IMPORTANT] @vlahane, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @vlahane, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @vlahane, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

matebarabas commented 2 months ago

@vlahane, I just pinged you internally regarding the inactivity on this module's development. Please let me know how you're planning to proceed. Thanks!

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] @vlahane, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 3 weeks ago

[!IMPORTANT] @vlahane, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 5 days ago

[!IMPORTANT] @vlahane, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.