Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.

https://aka.ms/AVM

MIT License

321 stars 68 forks source link

[Module Proposal]: `avm-res-insights-logprofile` (tf) #821

Open PmeshramPM opened 5 months ago

PmeshramPM commented 5 months ago

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-insights-logprofile

Module Details

Log profile Resource module

Do you want to be the owner of this module?

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

prjelesi commented 5 months ago

@PmeshramPM i am moving this request to 'Looking for owners"

sharmilamusunuru commented 4 months ago

@PmeshramPM @prjelesi I'll upvote myself to be module owner for this resource

PmeshramPM commented 4 months ago

Hi @sharmilamusunuru,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

sharmilamusunuru commented 4 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

On Mon, 29 Apr 2024, 20:07 Pankaj Meshram, @.***> wrote:

Hi @sharmilamusunuru https://github.com/sharmilamusunuru,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI https://azure.github.io/Azure-Verified-Modules/specs/shared/team-definitions

Shared Specification (Bicep & Terraform) https://azure.github.io/Azure-Verified-Modules/specs/shared

Module Support https://azure.github.io/Azure-Verified-Modules/help-support/module-support

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

— Reply to this email directly, view it on GitHub https://github.com/Azure/Azure-Verified-Modules/issues/821#issuecomment-2082921149 or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ32AGTV5VH43UH4DVBWYJTY7ZLJ5BFKMF2HI4TJMJ2XIZLTTKBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI2TSMBXG43DSOBQGGSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRVHEYDONZWHE4DOMFENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDKOJQG43TOMBUHA4KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGU4TGNRVGMYTEMBTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UNJZGUYDSNJUHAZDDJDOMFWWLKLIMFZV63DBMJSWZAVFOZQWY5LFVI3DANBYGE2DSNBRHCSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRWGA2DSMRVGI3TMMFENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZTAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTMNRQGIYTCNJXG2BKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIZDENZUGE3TSMBUQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRVHEYDONZWHE4DAMMCUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNJZGA3TONRZHA3TBAVEOR4XAZNFNRQWEZLMUV3GC3DVMWVDKOJQG43TOMBUHA4IFJDUPFYGLJLMMFRGK3FFOZQWY5LFVI2TSMZWGUZTCMRQGOBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGU4TKMBZGU2DQMRRQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRWGA2DQMJUHE2DCOECUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNRQGQ4TENJSG43DBJ3UOJUWOZ3FOKTGG4TFMF2GK . You are receiving this email because you were mentioned.

Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

prjelesi commented 4 months ago

Hi @sharmilamusunuru

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

For your module:
- ModuleName - for naming your module
- TelemetryIdPrefix - for your module's telemetry
For your module's repository:
- Repo name and folder path are defined in RepoURL
- Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
- Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

matebarabas commented 3 months ago

@sharmilamusunuru, please note that the name of this module was slight incorrect avm-res-insight-logprofile --> avm-res-insights-logprofile. I have just updated the title and description of this issue. I'll update this in the module index too. Please make sure that the name of the repository reflects this change too (note that the repo can be renamed). cc: @prjelesi, @PmeshramPM

sharmilamusunuru commented 3 months ago

I'm currently testing this module, will publish the commits soon

sharmilamusunuru commented 2 months ago

@PmeshramPM @prjelesi PR has been raised, however i've noticed that the resource is retiring soon as per https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/activity-log?tabs=powershell#managing-legacy-log-profiles---retiring. Do you still want me to push?

sharmilamusunuru commented 2 months ago

@PmeshramPM @prjelesi I've raised the PR however there's a bug identified in azapi during creation of this resource its unable to import the state as per https://github.com/Azure/terraform-azurerm-avm-res-insights-logprofile/actions/runs/9774001400/job/26981333653?pr=2

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] @sharmilamusunuru, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 1 week ago

[!IMPORTANT] @sharmilamusunuru, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.