search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
335 stars 71 forks source link

[Module Proposal]: `avm-res-containerinstance-containergroup` #846

Closed sharmilamusunuru closed 2 months ago

sharmilamusunuru commented 5 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-containerinstance-containergroup

Module Details

Resource module for Azure Container Instance

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

sharmilamusunuru

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

matt-FFFFFF commented 5 months ago

@prjelesi can we move this on and can the author start work?

We will need to correct the name

prjelesi commented 5 months ago

@matt-FFFFFF yap, i will process now.

@sharmilamusunuru

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

sharmilamusunuru commented 5 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

On Tue, 30 Apr 2024, 04:10 Predrag Jelesijevic, @.***> wrote:

@matt-FFFFFF https://github.com/matt-FFFFFF yap, i will process now.

@sharmilamusunuru https://github.com/sharmilamusunuru

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

— Reply to this email directly, view it on GitHub https://github.com/Azure/Azure-Verified-Modules/issues/846#issuecomment-2083807525 or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ32AGTVSTH43QTLJU7OKFTY73D43BFKMF2HI4TJMJ2XIZLTTCBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI2TSMBXG43DSOBQGGSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRVHEYDONZWHE4DOMFENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDKOJQG43TOMBUHA4KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGU4TGNRVGA4DGOJUURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UNJZGM3DKMZRGIYDHJDOMFWWLKLIMFZV63DBMJSWZLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOLYFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVE3DMMBSGEYTKNZWQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRSGIZTSMZUHEZDQNECUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNJZGA3TONRZHAYDDAVEOR4XAZNFNRQWEZLMUV3GC3DVMWVDKOJQG43TMOJYG4YIFJDUPFYGLJLMMFRGK3FFOZQWY5LFVI2TSMBXG43TANBYHCBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGU4TGNRVGA4DGOJUQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRVHEZTMNJTGEZDAM5HORZGSZ3HMVZKMY3SMVQXIZI . You are receiving this email because you were mentioned.

Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

prjelesi commented 5 months ago

Hi @sharmilamusunuru

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

sharmilamusunuru commented 4 months ago

Currently, I'm waiting for business review to finish.

sharmilamusunuru commented 3 months ago

This is currently in testing

sharmilamusunuru commented 2 months ago

@matt-FFFFFF @prjelesi can you please help to merge this PR as all PR checks are passed now https://github.com/Azure/terraform-azurerm-avm-res-containerinstance-containergroup/pull/22

sharmilamusunuru commented 2 months ago

@prjelesi @matt-FFFFFF @mbilalamjad this module has been published on the hashicorp registery can you please help to make the change in the AVM page?

image