Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.

https://aka.ms/AVM

MIT License

317 stars 65 forks source link

[Module Proposal]: `avm-res-insights-scheduledqueryrule` #885

Open bzabber opened 4 months ago

bzabber commented 4 months ago

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-insights-scheduledqueryrule

Module Details

A way to create Azure Monitor Log alerts (scheduled query alerts v2) using Terraform. It will reference an existing Azure Monitor Log Analytics workspace.

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

bzabber

(Optional) Secondary Module Owner's GitHub Username (handle)

JoeyBarnes

prjelesi commented 4 months ago

Hi @bzabber

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

bzabber commented 4 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

prjelesi commented 4 months ago

@bzabber i will ping you offline to clarify something.

prjelesi commented 4 months ago

Hi @bzabber ,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

For your module:
- ModuleName - for naming your module
- TelemetryIdPrefix - for your module's telemetry
For your module's repository:
- Repo name and folder path are defined in RepoURL
- Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
- Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

bzabber commented 3 months ago

@prjelesi Noticed that the module name in the For Module Owners & Contributors is doesn't align with the name of the resource and also doesn't align with its Bicep AVM counterpart. The module name should be "avm-res-insights-scheduledqueryrule". I've created the repo with the proper spelling, can you update your end?

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @bzabber, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

bzabber commented 2 months ago

@prjelesi Can you update the documentation for the modules as referenced in my previous comment? Please reach out if you have any questions or concerns.

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] @bzabber, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] @bzabber, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

PmeshramPM commented 1 month ago

I had a discussion with Bryan and Joseph. Going forward Joseph Barnes would be the new owner for this issue and Bryan would continue to contribute as external contributor. Thank you @bzabber for all the work & please continue to contribute.

microsoft-github-policy-service[bot] commented 12 hours ago

[!IMPORTANT] @bzabber, @JoeyBarnes, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.