Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.

https://aka.ms/AVM

MIT License

371 stars 90 forks source link

[Module Proposal]: `avm/res/kusto/cluster` #887

Closed mjhoffmeister closed 5 months ago

mjhoffmeister commented 7 months ago

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/kusto/cluster

Module Details

AVM bicep resource module for Kusto clusters.

Do you want to be the owner of this module?

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

matebarabas commented 7 months ago

Hi @mjhoffmeister, thank you for proposing this module. To proceed, I'd like to clarify an important question: Are you interested in being involved in the development/ownership of this module? If yes, are you Microsoft FTE?

Azure resource reference: https://learn.microsoft.com/en-us/azure/templates/microsoft.kusto/clusters?pivots=deployment-language-bicep Related AVM Terraform module: https://github.com/Azure/Azure-Verified-Modules/issues/533

mjhoffmeister commented 7 months ago

I'm not a Microsoft FTE, but I'd be happy to contribute to the module per the project guidelines.

matebarabas commented 7 months ago

I'm not a Microsoft FTE, but I'd be happy to contribute to the module per the project guidelines.

Just double checking: does this mean that you're happy to help build AND maintain this module (in the foreseeable future), along an FTE owner (administrative owner)? If yes, it will be much faster for us to identify someone who can help.

To make direct communication easier, can you please share under what name we may be able to find and contact you via LinkedIn? Also, can you please share which time zone you're based out of? Thank you!

mjhoffmeister commented 7 months ago

Yes, I can help build and maintain the module.

I sent you a connect request on LinkedIn (from Matt H.)

I'm in the US Central time zone.

matebarabas commented 7 months ago

That's great, thank you for confirming, and thanks for the connect request! (I've just accepted it.) I'll try to find and FTE in ATZ who can help you then! Please stay tuned!

oZakari commented 7 months ago

Hi @matebarabas and @mjhoffmeister, I can be the owner for this module.

Looking forward to working with you @mjhoffmeister!

matebarabas commented 7 months ago

Hi @oZakari,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

oZakari commented 7 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 7 months ago

Hi @oZakari,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

For your module:
- ModuleName - for naming your module
- TelemetryIdPrefix - for your module's telemetry
For your module's repository:
- Repo name and folder path are defined in RepoURL
- Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
- Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

matebarabas commented 7 months ago

@oZakari, please note that I had to change the module's name in the issue's name and description to avm/res/kusto/cluster (singular form). This was needed to make it aligned with the naming convention. I'll update the module index with the usual details (telemetryId, the names of the necessary GitHub teams, etc.).

oZakari commented 6 months ago

@mjhoffmeister and I have connected, and we have a shared branch we are working out of.

matebarabas commented 6 months ago

Thank you, @ozakari, for the updates! Please also feel free to submit a draft PR in the BRM repo (and share the link here) for maximum transparency! 😉 Thanks!

oZakari commented 6 months ago

Draft PR: https://github.com/Azure/bicep-registry-modules/pull/2186

oZakari commented 5 months ago

Just a call out to @mjhoffmeister for the fantastic work and heavy lifting he did to help get the module out the door!

cc: @matebarabas

matebarabas commented 5 months ago

[x] Module published.
[x] GitHub teams are available and assigned to their parents.
[x] CODEOWNERS file updated.

Thank you for your work @mjhoffmeister, @oZakari!