Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
324 stars 69 forks source link

[Module Proposal]: `avm-res-hybridcontainerservice-provisionedclusterinstance` #900

Closed xwen11 closed 3 weeks ago

xwen11 commented 5 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-hybridcontainerservice-provisionedclusterinstance

Module Details

This module is for provisioning AKS Arc through Terraform azapi. The code is ready https://github.com/Azure/Edge-infrastructure-quickstart-template/tree/main/modules/aks-arc

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

xwen11

(Optional) Secondary Module Owner's GitHub Username (handle)

duzitong

prjelesi commented 4 months ago

@jeanchg let sync about this.

PmeshramPM commented 4 months ago

@prjelesi & @jeanchg - I had a sync with @xwen11 and continuing the process based on that. Lets connect if you have any questions.

PmeshramPM commented 4 months ago

Hi @xwen11,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI Shared Specification (Bicep & Terraform) Module Support Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

xwen11 commented 4 months ago

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

prjelesi commented 4 months ago

@PmeshramPM just to confirm that this is resource module and not pattern? Example that is provided is also deploying network and subnet.

prjelesi commented 4 months ago

@xwen11 I will ping you for short sync.

xwen11 commented 4 months ago

@prjelesi can we have an update here? What's the next step?

prjelesi commented 4 months ago

Hi @xwen11 ,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @xwen11, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @xwen11, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @xwen11, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

prjelesi commented 1 month ago

@prjelesi explore possibilities to use azapi in repo

prjelesi commented 1 month ago

@xhy8759 as we agree we will proceed with azurerm in repo name

prjelesi commented 1 month ago

Index updated

xhy8759 commented 1 month ago

I would like to request a review of my module. The latest code is in a PR titled AVM-Review-PR on the module repo and all checks on that PR are passing. Here isour PR link: https://github.com/Azure/terraform-azurerm-avm-res-hybridcontainerservice-provisionedclusterinstance/pull/1

Test passes locally: aksarc

mbilalamjad commented 3 weeks ago

The initial review of this module is complete, and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index. Terraform Registry Link: https://registry.terraform.io/modules/Azure/avm-res-hybridcontainerservice-provisionedclusterinstance/azurerm/latest GitHub Repo Link: https://github.com/Azure/terraform-azurerm-avm-res-hybridcontainerservice-provisionedclusterinstance

xhy8759 commented 3 weeks ago

The initial review of this module is complete, and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index. Terraform Registry Link: https://registry.terraform.io/modules/Azure/avm-res-hybridcontainerservice-provisionedclusterinstance/azurerm/latest GitHub Repo Link: https://github.com/Azure/terraform-azurerm-avm-res-hybridcontainerservice-provisionedclusterinstance