Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
345 stars 81 forks source link

[Module Proposal]: `avm-res-edge-site` [tf] #906

Closed xwen11 closed 2 months ago

xwen11 commented 6 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-edge-site

Module Details

Terraform module to provision Arc Site Manager

The module code is ready https://github.com/Azure/Edge-infrastructure-quickstart-template/tree/export-scale-doc/modules/site-manager

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

xwen11

(Optional) Secondary Module Owner's GitHub Username (handle)

duzitong

microsoft-github-policy-service[bot] commented 6 months ago

[!IMPORTANT] The "Needs: Triage :mag:" label must be removed once the triage process is complete!

[!TIP] For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation.

[!NOTE] This label was added as per ITA06.

microsoft-github-policy-service[bot] commented 6 months ago

[!NOTE] The "Language: Terraform :globe_with_meridians:" label was added as per ITA14.

microsoft-github-policy-service[bot] commented 6 months ago

@xwen11, thanks for volunteering to be a module owner!

[!IMPORTANT] Please don't start the development just yet!

The AVM core team will review this module proposal and respond to you first. Thank you!

[!NOTE] This message was posted as per ITA17.

microsoft-github-policy-service[bot] commented 6 months ago

[!NOTE] The "Status: Owners Identified :metal:" label was added as per ITA16.

prjelesi commented 6 months ago

@jeanchg let sync about this.

xwen11 commented 6 months ago

Thanks! Do you want me to set up a meeting to discuss all of these three modules? @prjelesi and @jeanchg

prjelesi commented 5 months ago

@xwen11 we change name based on naming convention image

https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-rmnfr1---category-naming---module-naming

i will process this.

xwen11 commented 5 months ago

@prjelesi can we have an update here? What's the next step?

prjelesi commented 5 months ago

Hi @xwen11 ,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

microsoft-github-policy-service[bot] commented 4 months ago

[!IMPORTANT] @xwen11, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @xwen11, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

xhy8759 commented 3 months ago

Hello, we splited site manager to a module. We hope the Module Name to be renamed as avm-res-site-manager. Here is our repo: https://github.com/Azure/terraform-azapi-avm-res-site-manager And my PR is : https://github.com/Azure/terraform-azapi-avm-res-site-manager/pull/5 I renamed PR name to AVM-Review-PR as your requirement and invited team avm-core-team-technical-terraform to review. Could you help review it?

xhy8759 commented 3 months ago

@prjelesi Could you help check? Thanks! I would like to request a review of my module. The latest code is in a PR titled AVM-Review-PR on the module repo and all checks on that PR are passing.

xhy8759 commented 3 months ago

Refer: https://github.com/Azure/Azure-Verified-Modules/issues/1204

xhy8759 commented 3 months ago

image We run e2e test locally and it passed.

prjelesi commented 2 months ago

@prjelesi explore possibilities to use azapi in repo

prjelesi commented 2 months ago

@xhy8759 as we agree we will proceed with azurerm in repo name

prjelesi commented 2 months ago

Index is updated

mbilalamjad commented 2 months ago

The initial review of this module is complete, and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index. Terraform Registry Link: https://registry.terraform.io/modules/Azure/avm-res-edge-site/azurerm/latest GitHub Repo Link: https://github.com/Azure/terraform-azurerm-avm-res-edge-site