search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
318 stars 65 forks source link

[Module Proposal]: `avm-ptn-hci-server-provisioner` [tf] #908

Open xwen11 opened 4 months ago

xwen11 commented 4 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Pattern Module

Module Name

avm-ptn-hci-server-provisioner

Module Details

Terraform azapi module to execute Arc for Server registration

https://github.com/Azure/Edge-infrastructure-quickstart-template/tree/export-scale-doc/modules/hci-provisioners

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

xwen11

(Optional) Secondary Module Owner's GitHub Username (handle)

duzitong

prjelesi commented 4 months ago

@jeanchg can i get you feedback on this?

PmeshramPM commented 4 months ago

@prjelesi & @jeanchg - I had a sync with @xwen11 and continuing the process based on that. Lets connect if you have any questions.

PmeshramPM commented 4 months ago

Hi @xwen11,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

PmeshramPM commented 4 months ago

@prjelesi & @jeanchg - I had a sync with @xwen11 and continuing the process based on that. Lets connect if you have any questions.

PmeshramPM commented 4 months ago

Hi @xwen11,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI Shared Specification (Bicep & Terraform) Module Support Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

prjelesi commented 4 months ago

@PmeshramPM moving to pattern and updating name from 'Azure Stack HCI provisioner module` to new one.

prjelesi commented 4 months ago

@xwen11 we are changing this to pattern will process.

xwen11 commented 3 months ago

Hi, @prjelesi What's the next step?

prjelesi commented 3 months ago

Hi @xwen11

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

xhy8759 commented 1 month ago

We need to implement two modules: avm-ptn-hci-ad-provisioner and avm-ptn-hci-server-provisioner.

xhy8759 commented 1 month ago

I would like to request a review of my module. The latest code is in a PR titled AVM-Review-PR on the module repo and all checks on that PR are passing. Here are our PR links: https://github.com/Azure/terraform-azapi-avm-ptn-hci-ad-provisioner/pull/2 https://github.com/Azure/terraform-azapi-avm-ptn-hci-server-provisioner/pull/2

Tests pass locally: server ad

xhy8759 commented 1 month ago

As @mbilalamjad said, we cannot have two modules under one module proposal, they need to have individual module proposals approved. We hope to rename this module as avm-ptn-hci-server-provisioner, and I will submit a new proposal for another module as avm-ptn-hci-ad-provisioner. @prjelesi These two modules are hci preparation steps, the one-time setup scripts for hci AD and servers. No ARM resources are created by providers. Is thak OK?

prjelesi commented 1 month ago

@predrag to finish with this name

prjelesi commented 1 month ago

Index is updated

xhy8759 commented 1 month ago

I would like to request a review of my module. The latest code is in a PR titled AVM-Review-PR on the module repo and all checks on that PR are passing. Here are our PR links: https://github.com/Azure/terraform-azurerm-avm-ptn-hci-server-provisioner/pull/2

Tests pass locally: server

microsoft-github-policy-service[bot] commented 1 week ago

[!IMPORTANT] @xhy8759, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

xhy8759 commented 1 week ago

The initial review of this module is complete, and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index. Terraform Registry Link: https://registry.terraform.io/modules/Azure/avm-ptn-hci-server-provisioner/azurerm/latest GitHub Repo Link: https://github.com/Azure/terraform-azurerm-avm-ptn-hci-server-provisioner