search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
322 stars 68 forks source link

[Module Proposal]: `avm-ptn-azure-ipam` #913

Open ChrisChapman-gh opened 4 months ago

ChrisChapman-gh commented 4 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Pattern Module

Module Name

avm-ptn-azure-ipam

Module Details

A terraform pattern to deploy the https://azure.github.io/ipam/#/ container as a web app with supporting resources. Supported deployment models are the default public deployment or a virtual network integrated web app that can use service routes or private endpoints to access resources.

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

ChrisChapman-gh

ChrisChapman-gh commented 4 months ago

We (BJSS) have most of the terraform written which we can submit as a pull request from a fork. This should get the module most of the way there. Were also happy to contribute to the maintenance.

prjelesi commented 4 months ago

@ChrisChapman-gh thank for proposal. Give as a time to search for module owner.

pagyP commented 3 months ago

@prjelesi I'm happy to own and to work with BJSS on this

ChrisChapman-gh commented 3 months ago

That would be awesome, thanks Paul.

prjelesi commented 3 months ago

Hi @pagyP

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

pagyP commented 3 months ago

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

ChrisChapman-gh commented 2 months ago

Hi @prjelesi - What needs to happen next? can we get a repo spun up so I can fork it and start some PRs? Cheers Chris

prjelesi commented 2 months ago

Hi @pagyP

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

prjelesi commented 2 months ago

Hi @prjelesi - What needs to happen next? can we get a repo spun up so I can fork it and start some PRs? Cheers Chris

Hi @ChrisChapman-gh , @pagyP will initiate repo creation process and when it is created you will be able to fork and work.

Let me know if you need any help to move fw.

pagyP commented 2 months ago

@ChrisChapman-gh I've initiated the repository creation, just pending approval now.

pagyP commented 2 months ago

@ChrisChapman-gh repo should now be available https://github.com/Azure/terraform-azurerm-avm-ptn-azure-ipam (thanks for your patience ), please fork and submit a PR as per https://azure.github.io/Azure-Verified-Modules/contributing/terraform/review/

pagyP commented 1 week ago

@ChrisChapman-gh are you still planning/able to contribute to this? Let me know either way please., thanks.

ChrisChapman-gh commented 1 week ago

Hi Paul

Yes absolutely – had some leave and then straight onto a new project which has taken a lot of time to get up and running. I should have some time soon to fork and contribute.

Cheers Chris