jtracey93 commented 5 months ago

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/network/private-link-private-dns-zones

Module Details

Bicep replica of https://github.com/Azure/Azure-Verified-Modules/issues/613

Create all private DNS zones needed for private link supported services as per https://learn.microsoft.com/en-us/azure/private-link/private-endpoint-dns
Link to supplied vnets
Take in a location param to support things like azure backup geo code handling

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

jtracey93

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

matebarabas commented 5 months ago

Hi @jtracey93,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

jtracey93 commented 5 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 5 months ago

Hi @jtracey93,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

For your module:
- ModuleName - for naming your module
- TelemetryIdPrefix - for your module's telemetry
For your module's repository:
- Repo name and folder path are defined in RepoURL
- Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
- Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

jtracey93 commented 3 months ago

In progress, have just released the Terraform version

jtracey93 commented 3 months ago

This module is now published in BRM as of PR https://github.com/Azure/bicep-registry-modules/pull/2645

cc: @matebarabas @jeanchg

jtracey93 commented 2 months ago

This module is now published in BRM as of PR https://github.com/Azure/bicep-registry-modules/pull/2645

cc: @matebarabas @jeanchg

matebarabas commented 2 months ago

Thank you for your work @jtracey93!

[x] Module published.
[ ] GitHub teams are available and assigned to their parents. --> @jtracey93 the avm-ptn-network-privatelinkprivatednszones-module-contributors-bicep team is not assigned to its respective parent (avm-module-contributors-bicep). Can you please confirm when you've assigned it, so I can close this issue? Thanks!
[x] CODEOWNERS file updated.