search

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.
https://aka.ms/AVM
MIT License
322 stars 68 forks source link

[Module Proposal]: `avm-res-monitor-diagnostic-settings` #918

Open jrspinella opened 4 months ago

jrspinella commented 4 months ago

Check for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in the module indexes

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-monitor-diagnostic-settings

Module Details

This module can create Diagnostic Settings on a given Azure resource and manage related parameters.

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

jrspinella

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

prjelesi commented 4 months ago

@jrspinella diagnostic settings configuration is mandatory AVM module interface. Why you think that we should have this as separated module?

mathiasjespers commented 3 months ago

@jrspinella diagnostic settings configuration is mandatory AVM module interface. Why you think that we should have this as separated module?

This is indeed debatable, but a lot of people like to create a seperate module for diag settings and use that module instead of configuring it in each resource module. Call it a preference but this is is defininetly something people do

prjelesi commented 3 months ago

Agree. Let's keep this open and make it as request to collect feedback from field. Tnx @mathiasjespers

shghildi commented 1 week ago

Can u pls help me understand how to contribute for this module ?