Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.

https://aka.ms/AVM

MIT License

367 stars 89 forks source link

[Module Proposal]: `avm/res/azure-stack-hci/virtual-machine-instance` #934

Open mbrat2005 opened 7 months ago

mbrat2005 commented 7 months ago

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/azure-stack-hci/virtual-machine-instance

Module Details

Azure Stack HCI Virtual Machine Instances Deriving from https://github.com/Azure/azure-quickstart-templates/blob/master/quickstarts/microsoft.azurestackhci/vm-windows-disks-and-adjoin/main.bicep

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

mbrat2005

(Optional) Secondary Module Owner's GitHub Username (handle)

steveswalwell

matebarabas commented 6 months ago

Hi @mbrat2005,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

RR

mbrat2005 commented 6 months ago

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

matebarabas commented 6 months ago

Hi @mbrat2005,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

For your module:
- ModuleName - for naming your module
- TelemetryIdPrefix - for your module's telemetry
For your module's repository:
- Repo name and folder path are defined in RepoURL
- Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
- Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

mbrat2005 commented 6 months ago

Working on a bicep template to deploy the prereqs for an Azure Stack HCI cluster running in Azure to enable a testing pipeline. Once completed, I will prioritize the Azure/Azure-Verified-Modules#929 module before moving to Arc VM related modules

mbrat2005 commented 6 months ago

Temporary location for HCI host in Azure bicep template: https://github.com/mbrat2005/AzureHCIClusterDeploy

microsoft-github-policy-service[bot] commented 5 months ago

[!IMPORTANT] @mbrat2005, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

mbrat2005 commented 5 months ago

Depends on Azure/Azure-Verified-Modules#929, which is in progress

microsoft-github-policy-service[bot] commented 5 months ago

[!IMPORTANT] @mbrat2005, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

mbrat2005 commented 4 months ago

Blocked by: https://github.com/Azure/bicep-registry-modules/issues/3101

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @mbrat2005, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 3 months ago

[!IMPORTANT] @mbrat2005, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

mbrat2005 commented 2 months ago

Unblocked now that customer CI secret solution is merged

microsoft-github-policy-service[bot] commented 2 months ago

[!IMPORTANT] @mbrat2005, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 1 month ago

[!IMPORTANT] @mbrat2005, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 3 weeks ago

[!IMPORTANT] @mbrat2005, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.

microsoft-github-policy-service[bot] commented 1 day ago

[!IMPORTANT] @mbrat2005, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

[!TIP] To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term :hourglass_flowing_sand:" label.