search

Azure / AzureAD-BYOA-Provisioning-Samples

Samples to use the Microsoft.SystemForCrossDomainIdentityManagement libraries with BYOA for provisioning scenarios
Other
21 stars 19 forks source link

Azure Ad fails to update users using Patch #22

Open ashkansirous opened 5 years ago

ashkansirous commented 5 years ago

I have tested the API's using Postman and I can call them but when we test them with Azure AD the patch requests fail.

Looking at the logs and narrowing them down I've figured that the request is not in the same format as what microsoft.systemForCrossDomainIdentityManagement expects.

The patch request from AD is like below (which will fail):

{ "schemas":["urn:ietf:params:scim:api:messages:2.0:PatchOp"], 

"Operations": [ {"op":"Replace","path":"displayName","value":" User X"} ]}

While the request that the nuget expects is like this:


{"schemas":["urn:ietf:params:scim:api:messages:2.0:PatchOp"] ,

"Operations":[ {"op":"Replace","path":"displayName","value":

[ {"$ref":null,"value":"User x"}]}]

}

Please note the difference between 2 requests which in the 1st call is a string and in the second one is a list of objects.

How should I fix this?

The nuget package take the request and deliver the IPatchRequest so the requst doesn't even get to my part of the code :|

sven73a commented 4 years ago

Hi,

I run into to same issue.

How can this be fixed ?

Kind Regards, Sven Ansem

ashkansirous commented 4 years ago

@sven73a Please look at the update on the referenced issue. I have a work around for it by writing a middleware which by no way is clean or good, but the good news is that they have it in their backlog so hopefully they will come back to us with a nice Christmass gift :)

sven73a commented 4 years ago

@ashkansirous Thank a lot! I share your thoughts about the SampleApp, it's more complex than necessary, nevertheless I am happy with the SystemForCrossDomainIdentityManagement Dlls I also noticed that the SystemForCrossDomainIdentityManagement.Dlls (2.0.5.134) in the sample app are a more recent version than available via Nuget (2.0.5.95).

craigmcm commented 4 years ago

A revamp of the libraries and samples is underway.

Craig McMurtry Developer, Identity Platform

Microsoft Corporation Building 27 (South), Team Room 1030 1 Microsoft Way, Redmond, WA, 98052

Office: +1.425.707.9810|Mobile: +1.425.503.2854|Fax: +1.425.936.7329

From: Sven notifications@github.com Sent: Thursday, November 14, 2019 12:53 PM To: Azure/AzureAD-BYOA-Provisioning-Samples AzureAD-BYOA-Provisioning-Samples@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [Azure/AzureAD-BYOA-Provisioning-Samples] Azure Ad fails to update users using Patch (#22)

@ashkansiroushttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fashkansirous&data=02%7C01%7Ccraigmcm%40microsoft.com%7Cedf6551135044c5db7b508d769449275%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637093615552373293&sdata=IkfxQbExC83Qyi6p%2BrEPSrJspvM0sNbaE2wrjGvoMS4%3D&reserved=0 Thank a lot! I share your thoughts about the SampleApp, it's more complex than necessary, nevertheless I am happy with the SystemForCrossDomainIdentityManagement Dlls I also noticed that the SystemForCrossDomainIdentityManagement.Dlls (2.0.5.134) in the sample app are a more recent version than available via Nuget (2.0.5.95).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzureAD-BYOA-Provisioning-Samples%2Fissues%2F22%3Femail_source%3Dnotifications%26email_token%3DADMRDOYJ32SMIU2HPITVX7LQTW3BBA5CNFSM4GQ5XXI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEDICBA%23issuecomment-554074372&data=02%7C01%7Ccraigmcm%40microsoft.com%7Cedf6551135044c5db7b508d769449275%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637093615552378284&sdata=5lSP3Gk7l4SvdWB0dLSO6Gv%2Bkn4sSDDveRsygpE1DAk%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADMRDO7KZKRXRNUSSMKCRYTQTW3BBANCNFSM4GQ5XXIQ&data=02%7C01%7Ccraigmcm%40microsoft.com%7Cedf6551135044c5db7b508d769449275%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637093615552383276&sdata=WSP7pilIVtWkD90QJBh%2FbA8YoktBr8czUBD9RLPbSbM%3D&reserved=0.

sven73a commented 4 years ago

A revamp of the libraries and samples is underway.

Can you give any direction about ETA? is it this year, or Q1 2020 or even later? Or share preview of the libraries?