search

Azure / AzureStackHCI-EvalGuide

Welcome to the Azure Stack HCI Evaluation Guide!
Creative Commons Attribution 4.0 International
141 stars 84 forks source link

Consolidate node name and IP address variable at the beginning #37

Closed erjosito closed 3 years ago

erjosito commented 3 years ago

When creating a second host, the user needs to modify the value of the $nodeName and $newIP variables. However, the $nodeName is set multiple times during the script, and the $newIP is pretty buried in the code and hard to spot. I would suggest to put those at the very beginning of the code in https://github.com/Azure/AzureStackHCI-EvalGuide/blob/main/nested/steps/3b_AzSHCINodesPS.md, so that the code is more reusable.

Thanks!

mattmcspirit commented 3 years ago

Thank you - great catch. I'm working on some updates, so will capture this in an updated version. Thank you!

mattmcspirit commented 3 years ago

Hey - this should be fixed in the updated steps - thanks!