Azure / AzureStor

R interface to Azure storage accounts
Other
64 stars 20 forks source link

Add autologin environment variables to azcopy_auth() #127

Closed v-a-s-a closed 2 years ago

v-a-s-a commented 2 years ago

There have been some reported issues running azcopy in linux environments (e.g. #1840), likely due to issues integrating with keyctl. We have been experiencing similar issues running on Ubuntu VMs and containers. Our solution is using azcopy's autologin with a service principal. This does not rely on keyctl, just a handful of environment variables. This PR sets the appropriate environment variables before calling azcopy. I've run only manual tests but it has worked out well for our workflow.

It would be great to get this functionality in. Happy for suggestions or changes.

v-a-s-a commented 2 years ago

Any possibility of getting this approved? It is a simple change, and would be great to get this upstreamed.

ElliottMess commented 2 years ago

It would be great indeed if this could be approved!

v-a-s-a commented 2 years ago

Hi @hongooi73 — any chance this could be merged? It is the teeny, tiniest change. It conforms to Azure docs (see above). Not sure about testing, but happy to add something there if necessary.

hongooi73 commented 2 years ago

Sorry for the delay, merged

v-a-s-a commented 2 years ago

Legendary. Thank you @hongooi73!