search

Azure / AzureStor

R interface to Azure storage accounts
Other
64 stars 20 forks source link

Change to use lubridate::dmy_hms to convert Date/time string to POSIXct #99

Closed hidekoji closed 3 years ago

hidekoji commented 3 years ago

This PR addresses the issue that the below columns in list_storage_files result become NA for some occasion.

Switch to use lubridate::dmy_hms instead of as.POSIXct

format="%a, %d %b %Y %H:%M:%S" won't always work so use lubridate::dmy_hms to make it robust.

Changed API name from as_datetime to as_datetime_internal

as_datetime name conflicts with lubirdate::as_datetime conflicts, so to make it less confusing, change the API name to as_datetime_internal

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

hongooi73 commented 3 years ago

I want to keep AzureStor (and all the AzureR packages) as lightweight as possible, so pulling in extra dependencies just for one function doesn't sound like a great fix.

If you have a reproducible example of where the date can't be parsed, can you post it as an issue? Thanks.