search

Azure / Bio-Compliancy

MIT License
42 stars 18 forks source link

Wrong parameter definition #11

Closed marcomansiwestland closed 1 year ago

marcomansiwestland commented 1 year ago

https://github.com/Azure/Bio-Compliancy/blob/48cc443ca01d9fd0dfc00c5091b33fe386e7a315/ARM/BIO-azuredeploy.json#L3796

Hi, everywhere in the ARM/BIO-azuredeploy.json file are the parameters defined in a wrong way, with double [[

odegroot commented 1 year ago

Apparently, this is as intended.

https://learn.microsoft.com/en-us/azure/azure-resource-manager/templates/template-expressions

Escape characters

To have a literal string start with a left bracket [ and end with a right bracket ], but not have it interpreted as an expression, add an extra bracket to start the string with [[. For example, the variable:

"demoVar1": "[[test value]"

Resolves to [test value].

It seems that the escaping is required because the parameters are defined not at the ARM-template-level, but at the policySetDefinition-level.

I've tested the BIO-azuredeploy.json, deployed it and assigned it to some management group, and it indeed works as expected. My custom parameter values are correctly applied to the underlying policy.