search

Azure / Commercial-Marketplace-SaaS-Accelerator

A reference example with sample code for developers interested publishing transactable, Software as a-Service offers in the Microsoft commercial marketplace.
MIT License
193 stars 289 forks source link

Change service that gives the public IP of the client #636

Closed Giancarl021 closed 8 months ago

Giancarl021 commented 8 months ago

Related to #635.

This Pull Request changes the service that gives the client it's public IP address. The change is made to avoid an IPV6 to be fed into the firewall rule at the deployment of the SQL Server.

santhoshb-msft commented 8 months ago

@Giancarl021 Can I please confirm, this issue you are fixing during installation from your local env right?

Giancarl021 commented 8 months ago

@Giancarl021 Can I please confirm, this issue you are fixing during installation from your local env right?

Yes. I understand that the issue might be caused by my local environment. The fix is more of a suggestion if considered interesting.

santhoshb-msft commented 8 months ago

Thank you @Giancarl021 , I will let @msalemcode review this.