search

Azure / DotNetty

DotNetty project – a port of netty, event-driven asynchronous network application framework
Other
4.1k stars 978 forks source link

Added try-catch block while starting the watcherThread in ThreadDeath… #587

Closed yaziciahmet closed 2 years ago

yaziciahmet commented 2 years ago

ThreadDeathWatcher stops starting after some time, causing all the excess memory to be not cleaned, and causing a leak. It seems to be caused due to not handling the thread start exceptions, and started variable remains 1 even though the watcherThread is dead. I put it inside a try-catch block and converted it back to 0 if an exception occurs.

ghost commented 2 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: yaziciahmet sign now
You have signed the CLA already but the status is still pending? Let us recheck it.