Azure / DotNetty

DotNetty project – a port of netty, event-driven asynchronous network application framework
Other
4.09k stars 977 forks source link

Expose SslStream configuration options used in TlsHandler #60

Closed whizlingo closed 8 years ago

whizlingo commented 8 years ago

i am trying to host dot netty Client and server. When i monitor the tls traffic going on wireshark , i see the protocol set to tls 1.0 is their a way i can configure to do ssl handshake on tls 1.2

nayato commented 8 years ago

Unfortunately there is no way right now. To do that we'd need to pass a set of supported protocols here: https://github.com/Azure/DotNetty/blob/dev/src/DotNetty.Handlers/Tls/TlsHandler.cs#L250 The way TLS support is integrated right now is less than ideal and we plan to change that soon providing easier customization by accepting object that embeds SslStream integration. That way users will be able to override the defaults by inheriting or replacing such an object.

whizlingo commented 8 years ago

Thanks Max , that's exactly what I figured out yesterday, changed it to pass protocols similar to how we do for client and was able to see the desired results in wire shark. Thanks for your inputs.

Sent via Phone...

On 19-Dec-2015, at 2:57 PM, Max Gortman notifications@github.com wrote:

Unfortunately there is no way right now. To do that we'd need to pass a set of supported protocols here: https://github.com/Azure/DotNetty/blob/dev/src/DotNetty.Handlers/Tls/TlsHandler.cs#L250 The way TLS support is integrated right now is less than ideal and we plan to change that soon providing easier customization by accepting object that embeds SslStream integration. That way users will be able to override the defaults by inheriting or replacing such an object.

— Reply to this email directly or view it on GitHub.